Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup-javaで取ってくるJDKをキャッシュしてセルフホストランナーの転送量を節約する #797

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

korosuke613
Copy link
Owner

@korosuke613 korosuke613 commented Aug 15, 2024

No description provided.

@korosuke613 korosuke613 force-pushed the cache-corretto-on-self-hosted-gha branch 2 times, most recently from bc53bc2 to 09c0b5b Compare August 16, 2024 06:54
@korosuke613 korosuke613 force-pushed the cache-corretto-on-self-hosted-gha branch from 09c0b5b to b22516b Compare August 16, 2024 06:55
@korosuke613
Copy link
Owner Author

/ai-review

@korosuke613 korosuke613 marked this pull request as ready for review August 16, 2024 06:56
Copy link
Contributor

@korosuke613 AI Review finished. Please check the review comments.
https://github.com/korosuke613/zenn-articles/actions/runs/10415980716

{
  "tokens": {
    "prompt_tokens": 11821,
    "completion_tokens": 629,
    "total_tokens": 12450
  },
  "pricing": {
    "input": "0.059 USD",
    "output": "0.009 USD",
    "total": "0.069 USD"
  }
}

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@korosuke613 korosuke613 enabled auto-merge August 16, 2024 06:56
@korosuke613 korosuke613 merged commit 9e1bdbb into main Aug 16, 2024
4 checks passed
@korosuke613 korosuke613 deleted the cache-corretto-on-self-hosted-gha branch August 16, 2024 06:57
Copy link
Contributor

@Kesin11 Kesin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAT Gatewayの表記揺れ以外はLGTMです 👍

articles/cache-corretto-on-self-hosted-gha.md Show resolved Hide resolved
Installed distributions
Trying to resolve the latest version from remote
Print information about available versions
Retrieving available versions for Coretto took: 81.543ms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここのログ、 coretto でtypoしてるのを見つけてしまったw

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

僕はコピペしただけなので原点が間違ってますね。

...

なんと、すでに修正されてるけどリリースはされてない系のやつでした笑
actions/setup-java#666

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

面白かったので typo の件をちょっと追記しました。
449d0b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants