Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia07 #29

Merged
merged 31 commits into from
Aug 13, 2018
Merged

Julia07 #29

merged 31 commits into from
Aug 13, 2018

Conversation

korsbo
Copy link
Owner

@korsbo korsbo commented Aug 9, 2018

Get everything up an running on Julia 0.7 (and hopefully 1.0).

@korsbo korsbo changed the title Julia07 Julia0.7 Aug 11, 2018
@korsbo korsbo changed the title Julia0.7 Julia07 Aug 11, 2018
@coveralls
Copy link

coveralls commented Aug 13, 2018

Coverage Status

Coverage increased (+11.7%) to 91.459% when pulling ec54ee8 on julia07 into e6f3108 on master.

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #29 into master will increase coverage by 11.74%.
The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #29       +/-   ##
===========================================
+ Coverage   79.71%   91.45%   +11.74%     
===========================================
  Files          12       16        +4     
  Lines         345      281       -64     
===========================================
- Hits          275      257       -18     
+ Misses         70       24       -46
Impacted Files Coverage Δ
src/mdtable.jl 100% <ø> (+10%) ⬆️
src/latexalign.jl 100% <ø> (+36.11%) ⬆️
src/latexinline.jl 100% <ø> (+42.85%) ⬆️
src/md.jl 81.25% <ø> (+29.25%) ⬆️
src/latexarray.jl 100% <ø> (+10.52%) ⬆️
src/utils.jl 0% <0%> (ø)
src/latexify_function.jl 85% <0%> (+19.48%) ⬆️
src/latexoperation.jl 95.71% <100%> (+1.73%) ⬆️
src/Latexify.jl 100% <100%> (+66.66%) ⬆️
src/plugins/Missings.jl 100% <100%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f3108...583a7ec. Read the comment docs.

@korsbo
Copy link
Owner Author

korsbo commented Aug 13, 2018

Latexify now works fine, but Documenter.jl is giving me grief. If I were to merge this branch, the package would work with 0.7 and 1.0, but the documentation would not be generated correctly.

issue at Documenter.jl

Edit: This was due to a new default scoping of julias include function. Fixed.

@korsbo korsbo merged commit 6942ada into master Aug 13, 2018
@korsbo korsbo deleted the julia07 branch August 13, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants