Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nested comments in pragma parser #107

Closed
jan-christiansen opened this issue Dec 10, 2024 · 1 comment · Fixed by #109
Closed

Handle nested comments in pragma parser #107

jan-christiansen opened this issue Dec 10, 2024 · 1 comment · Fixed by #109

Comments

@jan-christiansen
Copy link
Contributor

The pragma parser is currently not able to parse nested comments. For example, ndmitchell/hlint contains modules with nested comments, for example https://github.com/ndmitchell/hlint/blob/ad9a1f8485eb34d40a59cc0bd1457d03fbffd50d/src/Hint/Bracket.hs#L5.

If this is of any interest, I will create a pull request that extends the parser to handle nested comments.
@tomjaguarpaw
Copy link
Collaborator

Yes, seems fine, thanks!

jan-christiansen added a commit to HS-Flensburg-PLTP/extensions that referenced this issue Dec 16, 2024
@jan-christiansen
[kowainik#107] Parse nested comments
6337d12
@jan-christiansen jan-christiansen mentioned this issue Dec 16, 2024
Merged
tomjaguarpaw pushed a commit that referenced this issue Dec 16, 2024
@jan-christiansen @tomjaguarpaw
[#107] Parse nested comments
6e17153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#107] Parse nested comments HS-Flensburg-PLTP/extensions
2 participants
@jan-christiansen @tomjaguarpaw