Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for concise Kotlin code style, compile under JDK 23 #191

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

kpavlov
Copy link
Owner

@kpavlov kpavlov commented Oct 28, 2024

Updating the Java versions in the GitHub Actions workflow, enhancing the readability of constructors and methods, and adding trailing commas for better diff readability.

kpavlov added 2 commits October 28, 2024 21:47
Adjusted formatting for better readability by aligning indentation and replacing multiline function bodies with single-line expressions. Updated enumeration and class definitions to include trailing commas, where appropriate, to prepare for future modifications.
Replaced JDK version 22 with 23 in the GitHub Actions workflow file. This ensures the build process is tested with the latest Java Development Kit version.
Added missing documentation
@kpavlov kpavlov changed the title Refactor for concise Kotlin code style Refactor for concise Kotlin code style, compile under JDK 23 Oct 28, 2024
kpavlov added 3 commits October 28, 2024 21:56
Added `fail-fast: false` to the matrix strategy to ensure that all jobs are executed even if one fails. This change aims to provide complete feedback for all configurations tested.
Change socketAddress from var to val for immutability. Add `@Suppress("UnnecessaryAbstractClass")` to avoid compiler warning in ConnectorConfiguration.
Added JVM target 17 to Detekt configuration to ensure compatibility with project's JVM version. Adjusted formatting for consistency in `testLogging` and `manifest` attributes settings.
@kpavlov kpavlov marked this pull request as ready for review October 28, 2024 20:17
@kpavlov kpavlov enabled auto-merge (squash) October 28, 2024 20:17
@kpavlov kpavlov disabled auto-merge October 28, 2024 20:18
@kpavlov kpavlov merged commit a48724d into main Oct 28, 2024
4 checks passed
@kpavlov kpavlov deleted the refactor branch October 28, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant