Code

WIP: Reorganization#164

Code

Merged

kputnam merged 98 commits intomasterkputnam/stupidedi:masterfrom pr-reorganizekputnam/stupidedi:pr-reorganizeCopy head branch name to clipboardMar 27, 2019

+106,277-173,265

Commits

Commits on Jan 2, 2019

• Reorganize/rename modules for interchanges and X12 versions

  kputnam

  committed
  abf8148

  Copy full SHA for abf8148

Commits on Jan 3, 2019

• Reorganize and reduce code/definition duplication

  kputnam

  committed
  85a94fa

  Copy full SHA for 85a94fa

• Merge remote-tracking branch 'github/master' into pr-reorganize

  kputnam

  committed
  cee9d37

  Copy full SHA for cee9d37

Commits on Jan 4, 2019

• Fix 5010 BE834 standard

  kputnam

  committed
  358a318

  Copy full SHA for 358a318

• Rename Stupidedi::Builder to Stupidedi::Parser

  kputnam

  committed
  193de45

  Copy full SHA for 193de45

• Define stub segments and uncomment references to them in X12 standards, revealing a couple more instances of ambiguous grammar

  kputnam

  committed
  a9d81aa

  Copy full SHA for a9d81aa

Commits on Jan 6, 2019

• Fix incorrect nesting in 837I (fix #155)

  kputnam

  committed
  831c7e3

  Copy full SHA for 831c7e3

• Fix incorrect nesting in RA820

  kputnam

  committed
  88d553d

  Copy full SHA for 88d553d

• Fix incorrect nesting in HB271

  kputnam

  committed
  5f97b48

  Copy full SHA for 5f97b48

Commits on Jan 7, 2019

• Replace rspec should syntax, impose more consistent formatting

  kputnam

  committed
  34930b7

  Copy full SHA for 34930b7

• Improve code coverage reporting

  kputnam

  committed
  9ec0e21

  Copy full SHA for 9ec0e21

• Make sure #to_d fails on invalid input (unlike bigdecimal/utilsimplementation)

  kputnam

  committed
  480ca05

  Copy full SHA for 480ca05

• Remove JRuby hack, we'll check if build passes on TravisCI

  kputnam

  committed
  dad95ab

  Copy full SHA for dad95ab

Commits on Jan 9, 2019

• More formatting changes

  kputnam

  committed
  4feea07

  Copy full SHA for 4feea07

Commits on Jan 10, 2019

• Detect (hypothetical?) new case of ambiguity; Cleanup error-reporting in Validation::Ambiguity, add specs

  kputnam

  committed
  cf73ccd

  Copy full SHA for cf73ccd

• Deprecate Stupidedi::Builder

  kputnam

  committed
  a11c9b5

  Copy full SHA for a11c9b5

Commits on Jan 11, 2019

• Reorganize fixtures for increased automation of specs

  kputnam

  committed
  de099e5

  Copy full SHA for de099e5

• Deprecate (rename) HC837P and HC837I to X222::HC837 and X223::HC837

  kputnam

  committed
  290a6aa

  Copy full SHA for 290a6aa

• Add missing segment terminator after IEA; change segment terminator from a char already used in data elements

  kputnam

  committed
  fb724ba

  Copy full SHA for fb724ba

Commits on Jan 12, 2019

• Further obfuscation

  kputnam

  committed
  02bb38d

  Copy full SHA for 02bb38d

• New examples

  kputnam

  committed
  80c63f3

  Copy full SHA for 80c63f3

• Deprecate Stupidedi::Contrib, Stupidedi::Guides, Stupidedi::Versions::FunctionalGroups, Stupidedi::Versions::Interchanges

  kputnam

  committed
  3f55671

  Copy full SHA for 3f55671

• Remove old cruft from notes/

  kputnam

  committed
  8f4f57c

  Copy full SHA for 8f4f57c

Commits on Jan 13, 2019

• Comment-out problematic loop in Standards::HB271 (implementation is fine)

  kputnam

  committed
  bfe71a4

  Copy full SHA for bfe71a4

• Remove Symbol#call refinement

  kputnam

  committed
  933e29b

  Copy full SHA for 933e29b

• Tell Code Climate to ignore large definitions files

  kputnam

  committed
  37dc152

  Copy full SHA for 37dc152

• Fix Travis CI build for older versions of Ruby

  kputnam

  committed
  953dafa

  Copy full SHA for 953dafa

• Load SimpleCov first so lib/ruby and others are tracked

  kputnam

  committed
  771db19

  Copy full SHA for 771db19

• Merge branch 'master' into pr-reorganize

  kputnam

  committed
  3e5d5f8

  Copy full SHA for 3e5d5f8

Commits on Jan 14, 2019

• Make TableDef.detail not repeatable, only the table's child loop can repeat (#126)

  kputnam

  committed
  b806f1b

  Copy full SHA for b806f1b

Commits on Jan 15, 2019

• Many more 005010 HIPAA fixture files

  kputnam

  committed
  3819e03

  Copy full SHA for 3819e03

Commits on Jan 16, 2019

• - Made TableDef.detail not repeatable, and changed each table's direct

  Show description for 3daab21
  kputnam

  committed
  3daab21

  Copy full SHA for 3daab21

Commits on Jan 17, 2019

• Use new set of 005010 fixtures

  kputnam

  committed
  71dc482

  Copy full SHA for 71dc482

• Add placeholderss for missing 005010 qualifier values for RA820

  kputnam

  committed
  c5ed718

  Copy full SHA for c5ed718

• Fix errors in FiftyTen::Standards::HP835 (incorrect parentheses,

  Show description for d0d37ae
  kputnam

  committed
  d0d37ae

  Copy full SHA for d0d37ae

• Add missing qualifier code values for HI278

  kputnam

  committed
  e0dc2cd

  Copy full SHA for e0dc2cd

• Add missing qualifier codes for HC837s, fix X291 HC837 fixture file that

  Show description for cb625ef
  kputnam

  committed
  cb625ef

  Copy full SHA for cb625ef

• Disable FiftyTen::Standards::HB-271 for now, see #173

  kputnam

  committed
  9d9db98

  Copy full SHA for 9d9db98

Commits on Jan 18, 2019

• Add missing quailfier code values for BE834

  kputnam

  committed
  4c3d0a3

  Copy full SHA for 4c3d0a3

• Implement FiftyTen::Standards::FA997, add missing qualifier codes

  kputnam

  committed
  7a26278

  Copy full SHA for 7a26278

• Add missing qualifier codes for BE834 (for X307 which is not

  Show description for f5fb835
  kputnam

  committed
  f5fb835

  Copy full SHA for f5fb835

• Fix wrong GS01 value for HN277 fixture files

  kputnam

  committed
  b67bea0

  Copy full SHA for b67bea0

• Merge detail tables of X212 HR276 into one table, to avoid issues caused

  Show description for 51d4b3d
  kputnam

  committed
  51d4b3d

  Copy full SHA for 51d4b3d

• Remove extraneous periods at end of description strings (cosmetic

  Show description for 72fa58f
  kputnam

  committed
  72fa58f

  Copy full SHA for 72fa58f

• Squash me! X214-HN277 with * 51d4b3d Merge detail tables of X212 HR276 into one table...

  kputnam

  committed
  36b6114

  Copy full SHA for 36b6114

• Fix deprecation warnings for X221::HP835, X222::HC837, X222::HC837P,

  Show description for 330a46f
  kputnam

  committed
  330a46f

  Copy full SHA for 330a46f

• Remove Ruby 1.9 shims for #instance_exec (was only used in QuickCheck)

  Show description for 973c1c7
  kputnam

  committed
  973c1c7

  Copy full SHA for 973c1c7

• Use Stupidedi::Parser.build as a shortcut for Stupidedi::Parser::StateMachine.build

  kputnam

  committed
  ef8d391

  Copy full SHA for ef8d391

• Improve error messages

  kputnam

  committed
  05a8edd

  Copy full SHA for 05a8edd

• Specs to ensure ElementDefs and SegmentDefs have correct id

  kputnam

  committed
  f09821b

  Copy full SHA for f09821b

• Swap confusing names Deepest/Shallowest, fix a couple broken specs

  kputnam

  committed
  32e75cf

  Copy full SHA for 32e75cf

• Merge remote-tracking branch 'github/master' into pr-reorganize

  kputnam

  committed
  36519a6

  Copy full SHA for 36519a6

Commits on Jan 21, 2019

• Use 005010X223A2 (see #174); disable broken implementation guides

  Show description for 084cdeb
  kputnam

  committed
  084cdeb

  Copy full SHA for 084cdeb

• Deprecate IdentifierStack#pop in favor of more explicit #pop_isa,

  kputnam

  committed
  b5d4462

  Copy full SHA for b5d4462

• Implement Reader::Position#to_s and better handle missing column number;

  Show description for a849b04
  kputnam

  committed
  a849b04

  Copy full SHA for a849b04

• Disable broken implementation 002001 FA999

  kputnam

  committed
  e5f6a03

  Copy full SHA for e5f6a03

• Make sure InvalidSegmentVal#descriptor says "segment" to be consistent

  kputnam

  committed
  fbce21a

  Copy full SHA for fbce21a

• Improved Parser::BuilderDsl specs that more closely match how it's used

  Show description for 788ec98
  kputnam

  committed
  788ec98

  Copy full SHA for 788ec98

• Fix RSpec warnings about false positives with raise_error()

  kputnam

  committed
  3925732

  Copy full SHA for 3925732

• Fix a few issues with SegmentTok#to_s and friends

  kputnam

  committed
  f8e211f

  Copy full SHA for f8e211f

• Update BuilderDsl specs to account for validations that happen "late",

  Show description for 1dd0009
  kputnam

  committed
  1dd0009

  Copy full SHA for 1dd0009

Commits on Jan 22, 2019

• Enable ruby warnings (-w) in rake spec and clear up all existing

  Show description for 1c32117
  kputnam

  committed
  1c32117

  Copy full SHA for 1c32117

• Make deprecation warnings more notiable

  kputnam

  committed
  72adb03

  Copy full SHA for 72adb03

Commits on Jan 25, 2019

• Print code coverage summary on the console, generate one single HTML coverage file

  kputnam

  committed
  698ff6e

  Copy full SHA for 698ff6e

• Use InvalidSchemaError, instead of ArgumentError, in SimpleElementDef

  Show description for 32cfb28
  kputnam

  committed
  32cfb28

  Copy full SHA for 32cfb28

• Deprecate 005010X231 FA999 because 005010X31A1 supercedes it and is

  Show description for ba4417f
  kputnam

  committed
  ba4417f

  Copy full SHA for ba4417f

• Address questions in #172 regarding tables: if a table begins with a

  Show description for e210699
  kputnam

  committed
  e210699

  Copy full SHA for e210699

• Update specs for specific TransactionSetDefs

  kputnam

  committed
  26211e5

  Copy full SHA for 26211e5

• Oops, simplecov-* requires Ruby 2.4+

  kputnam

  committed
  0ec0592

  Copy full SHA for 0ec0592

• Merge remote-tracking branch 'github/master' into pr-reorganize

  kputnam

  committed
  e845fb8

  Copy full SHA for e845fb8

Commits on Jan 29, 2019

• Write many more specs; improve readability of existing specs

  kputnam

  committed
  2657bdf

  Copy full SHA for 2657bdf

• Temporarily ignore test coverage stats on Stupidedi::Editor; print a

  Show description for 6020930
  kputnam

  committed
  6020930

  Copy full SHA for 6020930

• Add --format <html|tree|x12> argument to edi-pp

  kputnam

  committed
  740814e

  Copy full SHA for 740814e

• Remove dead code; when an ID value is part of the entire CodeList, but

  Show description for ed3f78f
  kputnam

  committed
  ed3f78f

  Copy full SHA for ed3f78f

• Improve the appearance of Claredi (HTML) writer

  kputnam

  committed
  ac662be

  Copy full SHA for ac662be

• Fix various issues revealed by new specs

  kputnam

  committed
  36a3976

  Copy full SHA for 36a3976

• Fix build issues

  kputnam

  committed
  3accf50

  Copy full SHA for 3accf50

• Fix build issues

  kputnam

  committed
  7a5e5ee

  Copy full SHA for 7a5e5ee

Commits on Feb 8, 2019

• Fix missing images in simplecov report

  kputnam

  committed
  a84ba7a

  Copy full SHA for a84ba7a

• Print timing info to STDERR instead of STDOUT

  kputnam

  committed
  a1b4350

  Copy full SHA for a1b4350

• Improve #find error message when segment cannot or does not occur

  kputnam

  committed
  da5f9d7

  Copy full SHA for da5f9d7

• Make clearer how GS001, GS08, ST01, and ST03 are used to identify a TransactionSetDef

  kputnam

  committed
  431272b

  Copy full SHA for 431272b

• Implement be_failure matcher, deprecate

  kputnam

  committed
  0d61a05

  Copy full SHA for 0d61a05

• Give reason for pending specs

  kputnam

  committed
  efa91e2

  Copy full SHA for efa91e2

• Improve support for composite and repeated elements in specs (by using a custom SegmentDict)

  kputnam

  committed
  8561945

  Copy full SHA for 8561945

• Merge branch 'pr-reorganize' of https://github.com/irobayna/stupidedi into pr-reorganize

  kputnam

  committed
  4b0f899

  Copy full SHA for 4b0f899

Commits on Feb 9, 2019

• Fix build error

  kputnam

  committed
  f242765

  Copy full SHA for f242765

• Put all build artifacts in build/generated, fix some YARD configuration issues

  kputnam

  committed
  5dd1c39

  Copy full SHA for 5dd1c39

Commits on Feb 10, 2019

• Fix another build error

  kputnam

  committed
  ec7e464

  Copy full SHA for ec7e464

Commits on Feb 12, 2019

• Improve error message consistency in BuilderDsl-adjacent code; Write

  Show description for 1235c80
  kputnam

  committed
  1235c80

  Copy full SHA for 1235c80

Commits on Feb 15, 2019

• Make SimpleElementVals behave more consistently across types (AN, DT, ID, Nn, R, TM)

  Show description for 7648764
  kputnam

  committed
  7648764

  Copy full SHA for 7648764

• Implement specs for BuilderDsl regarding validation of tables, and

  Show description for e3fd1b1
  kputnam

  committed
  e3fd1b1

  Copy full SHA for e3fd1b1

• Remove dead code

  kputnam

  committed
  1ea33ca

  Copy full SHA for 1ea33ca

Commits on Feb 18, 2019

• Check number of occurences for repeated elements when BuilderDsl is

  Show description for 5876e7f
  kputnam

  committed
  5876e7f

  Copy full SHA for 5876e7f

• Trim crud at the end of numbers in Nn#inspect and Nn#to_s

  kputnam

  committed
  1075436

  Copy full SHA for 1075436

• Fix YARD complaints

  kputnam

  committed
  fed3dee

  Copy full SHA for fed3dee

• Comments for formatters in .simplecov

  kputnam

  committed
  dbb229f

  Copy full SHA for dbb229f

Commits on Mar 9, 2019

• Fix a regression in Navigation#element

  kputnam

  committed
  7b887e9

  Copy full SHA for 7b887e9