Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add osm data loader based on pbf files #205

Merged
merged 24 commits into from
Mar 21, 2023

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Mar 16, 2023

No description provided.

@RaczeQ RaczeQ linked an issue Mar 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #205 (a099b56) into main (070f7e3) will decrease coverage by 5.39%.
The diff coverage is 81.50%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   99.02%   93.64%   -5.39%     
==========================================
  Files          34       41       +7     
  Lines         823     1117     +294     
==========================================
+ Hits          815     1046     +231     
- Misses          8       71      +63     
Flag Coverage Δ
macos-latest-python3.10 93.64% <81.50%> (-5.39%) ⬇️
ubuntu-latest-python3.10 93.55% <81.50%> (-5.36%) ⬇️
ubuntu-latest-python3.8 93.54% <81.50%> (-5.36%) ⬇️
ubuntu-latest-python3.9 93.54% <81.50%> (-5.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/constants.py 100.00% <ø> (ø)
srai/exceptions.py 100.00% <ø> (ø)
srai/loaders/osm_loaders/filters/__init__.py 100.00% <ø> (ø)
srai/utils/download.py 36.36% <50.00%> (ø)
srai/loaders/osm_loaders/pbf_file_downloader.py 55.14% <55.14%> (ø)
srai/utils/geocode.py 62.50% <62.50%> (ø)
srai/loaders/osm_loaders/osm_pbf_loader.py 92.10% <92.10%> (ø)
srai/loaders/osm_loaders/pbf_file_handler.py 96.47% <96.47%> (ø)
srai/embedders/gtfs2vec_embedder.py 100.00% <100.00%> (ø)
srai/joiners/intersection_joiner.py 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RaczeQ RaczeQ marked this pull request as ready for review March 17, 2023 21:40
simonusher
simonusher previously approved these changes Mar 20, 2023
@RaczeQ RaczeQ requested a review from piotrgramacki March 21, 2023 07:59
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@RaczeQ RaczeQ merged commit 78d0fbb into main Mar 21, 2023
@RaczeQ RaczeQ deleted the 52-add-osmloader-based-on-pbf-geofabrik branch March 21, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSMLoader based on pbf / geofabrik
3 participants