refactor: remove utils module (#128) #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 92.23% 91.85% -0.38%
==========================================
Files 61 60 -1
Lines 2023 2113 +90
==========================================
+ Hits 1866 1941 +75
- Misses 157 172 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Calychas
previously approved these changes
Jul 20, 2023
RaczeQ
commented
Jul 27, 2023
| wkb = [geometry.wkb] | ||
|
|
||
| h3_indexes = wkb_to_cells( | ||
| wkb, resolution=h3_resolution, all_intersecting=buffer, flatten=True |
There was a problem hiding this comment.
I really like the all_intersecting parameter name. It seems more descriptive than buffer in my opinion. We could replace it in H3 and S2 Regionalizers.
There was a problem hiding this comment.
neither buffer nor all_intersecting is descriptive enough for me hah. Do we have a better alternative?
Calychas
previously approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.