Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: improve reproducibility #987

Merged
merged 1 commit into from
Jul 30, 2024
Merged

clang: improve reproducibility #987

merged 1 commit into from
Jul 30, 2024

Conversation

raburaibu
Copy link
Contributor

@raburaibu raburaibu commented Jul 30, 2024

Currently, class-target is reproducible, but class-nativesdk is not. What I did:

  • noticed that BuildVariables.inc contains meaningless path fragments after running sed, so I adjusted sed commands to remove the rest of paths as well;
  • moved common code into a function, which is then called twice;
  • changed do_compile:prepend into do_configure:append, this is more conventional and intuitive;
  • verified that the resulting code works for both target and nativesdk after these changes.

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Currently, class-target is reproducible, but
class-nativesdk is not. What I did:

- noticed that BuildVariables.inc contains meaningless
path fragments after running sed, so I adjusted sed
commands to remove the rest of paths as well;
- moved common code into a function, which is then
called twice;
- changed do_compile:prepend into do_configure:append,
this is more conventional and intuitive;
- verified that the resulting code works for both
target and nativesdk after these changes.

Signed-off-by: Oleh Matiusha <[email protected]>
@raburaibu raburaibu requested a review from kraj as a code owner July 30, 2024 07:44
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this LGTM

@kraj kraj merged commit 0b2616e into kraj:master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants