Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler-rt-sanitizers: Package a symlink to address headers include … #997

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

FederAndInk
Copy link

…issue

Instead of moving the whole install under major.minor.patch, create a symlink so both can be included

Fixes #978

Signed-off-by: Khem Raj [email protected]
Signed-off-by: Ludovic Jozeau [email protected]

(cherry picked from commit a219212)


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

…issue

Instead of moving the whole install under major.minor.patch, create a symlink
so both can be included

Fixes kraj#978

Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Ludovic Jozeau <[email protected]>

(cherry picked from commit a219212)
@FederAndInk FederAndInk requested a review from kraj as a code owner August 12, 2024 10:46
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit 7d9bf6d into kraj:scarthgap Aug 15, 2024
@FederAndInk FederAndInk deleted the scarthgap branch August 15, 2024 06:31
@FederAndInk FederAndInk restored the scarthgap branch August 15, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants