update #38 - add a semicolon rule in eslintrc.js #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jchoi136 -- this rule is enabled by design. But per my question at #38 -- are you sure this isn't happening for you because of local changes? Right now there are no failures for master branch in travis due to this rule... |
|
Seems like the code has semicolons. This change makes it explicit that having semicolons should not trigger errors. Wouldn't it be better to make this explicit? |
|
@songz -- as in, it's enabled intentionally. All of the rules are set here: https://github.com/krakenjs/grumbler-scripts/blob/master/config/.eslintrc.js#L236 Not sure what you mean by "make this explicit" -- the rule is explicitly turned on in this shared config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #38
This PR fixes a semicolon issue during npm run lint.
Example of error
Should I change this in this repo or in https://github.com/krakenjs/grumbler-scripts/blob/master/config/.eslintrc-browser.js?