Fix rule violation in sifrr

[aadityataparia]

From #516 (comment)

[aadityataparia]

@krausest Please 🙏

[aadityataparia]

@krausest I have a question regarding select implementation:

Before

• Save selected element directly, and update on change of selected element
  This is a no go according to rule 👍

This PR

• Loop through all the rows and select row which user selected and deselect any previously selected row.

Question

But will this be considered a rule violation:

• Save selected row id, and deselect old selected row id and select new selected row id?

This will save loop run time.

[StefansArya]

It seems you have fall in the same hole like me 😄

The purpose of the test is for measuring the framework speed, and not the direct DOM manipulation speed. I think it's okay to save the id of the item, but you must apply any changes with the framework itself..

[krausest]

@aadityataparia You mean like here?
If you save it in the model and use it for initial rendering you should be safe.

[ryansolid]

The only thing I'd consider with such a solution is ensure that swap still works as intended (if the selected row was the one being swapped). I'm not as familiar with if it is different in non-keyed but make sure the functionality works the same. While there aren't testing for all the edge cases you want to make sure your implementation makes sense from how a user would expect interactions to work on a list in which items can be re-ordered and selected at will.

[aadityataparia]

@krausest Saving it then,

But there's one thing I noticed that if you save the index of selected row, and then delete a row above this row, and then select some other row, it won't deselect old row since the saved index is not correct anymore. 🤷‍♂️

---

EDIT:

Can be fixed by adding index decrement logic in delete event listener though. or getting old selected index during select.

On a second note I think i will just find last selected row without saving it to keep expected behaviour in all edge cases.

[krausest]

Thanks. Results have been updated!