Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error for ScarletsFrame #528

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Fix build error for ScarletsFrame #528

merged 5 commits into from
Feb 28, 2019

Conversation

StefansArya
Copy link
Contributor

About this pull request:

  • Fix error when compiling the framework with babel because unsupported regular expression.
  • Update the framework, test implementation, and the title for non-keyed test
  • Fix hangs for the test driver

BTW, how to check the the test driver about the hangs?
I'm not sure it was solved or not because I don't see anything wrong when I test it with my computer.

@krausest krausest merged commit 1596ae2 into krausest:master Feb 28, 2019
@krausest
Copy link
Owner

Thanks - results have been updated.
It still hangs without the patch. You can try it if you follow the readme and run in webdriver-ts npm run compile and then npm run bench -- --framework scarletsframe-keyed.
Just remove https://github.com/krausest/js-framework-benchmark/blob/master/webdriver-ts/src/forkedBenchmarkRunner.ts#L476-L479 and recompile and test again. It only works for the first run and hangs for subsequent ones unless the wait condition is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants