Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation #1141

Closed
wants to merge 2 commits into from
Closed

Add Ukrainian translation #1141

wants to merge 2 commits into from

Conversation

egorsmkv
Copy link

This pull request adds a Ukrainian locale to the CRM

@Sanjaybhattwebkul
Copy link
Contributor

Hi there,
The locale name is not visible inside the configuration, please find the screenshot Here

@Sanjaybhattwebkul
Copy link
Contributor

Sanjaybhattwebkul commented Jan 12, 2023

Please Ukrainian locale Here. if you created locale file for all packages.

@egorsmkv
Copy link
Author

@Sanjaybhattwebkul fixed

@egorsmkv
Copy link
Author

@Sanjaybhattwebkul it seems like CI failed due a NodeJS problem

@Sanjaybhattwebkul
Copy link
Contributor

Hi there,
This is working fine, please find the screenshot Here

@Sanjaybhattwebkul
Copy link
Contributor

For CI, i am re-running the jobs again.

@egorsmkv
Copy link
Author

The width of the left sidebar was small in my tests for some translations. Do you see it during the test?

@Sanjaybhattwebkul
Copy link
Contributor

Sanjaybhattwebkul commented Jan 12, 2023

@egorsmkv
Are you asking about this issue?

@egorsmkv
Copy link
Author

Yep, correct. Exactly, that issue.

@Sanjaybhattwebkul
Copy link
Contributor

This is a separate issue. you can create a pull request for this issue. this will be appreciated.

@egorsmkv
Copy link
Author

Okay, I have other things to be done in Ukrainian translation so you're right, it's better to have another PR for fixing those issues.

@Sanjaybhattwebkul
Copy link
Contributor

Sanjaybhattwebkul commented Jan 13, 2023

Okay, I have other things to be done in Ukrainian translation so you're right, it's better to have another PR for fixing those issues.

A separate issue is raised for the same. you can create a Pull request.

#1146

@egorsmkv egorsmkv closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants