Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack build #303

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix webpack build #303

merged 2 commits into from
Oct 27, 2023

Conversation

kreneskyp
Copy link
Owner

Description

A package released today-ish broke the webpack build. Wasn't able to identify the culprit but an older package-lock.json (09/10/2023) is still functional. Adding the package-lock to the Dockerfile.

Changes

[List out the changes you've made in this pull request. Be as specific as possible.]

How Tested

[Explain how you tested this pull request. Include any relevant steps or scripts.]

TODOs

Deal with the erroneous package later:

  • The build broke on prism, and refactor which are both installed by react-syntax-highlighter. Both of these are very old packages so they might not see an update.
  • Could be an issue with a newer babel or webpack

@kreneskyp kreneskyp merged commit 381b6f8 into master Oct 27, 2023
6 checks passed
@kreneskyp kreneskyp deleted the fix_webpack_build branch October 27, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant