Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONSchema should use schema description when used for function call #432

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

kreneskyp
Copy link
Owner

Description

Schema objects were using instance.description but not the schema within the schema definition json.

Did some research and determined that OpenAI ignores parameters.description in a function call definition. There may be useful instructions in the schema so to_openaj_fn helper now joins both description values together for the fn description.

Changes

[List out the changes you've made in this pull request. Be as specific as possible.]

How Tested

[Explain how you tested this pull request. Include any relevant steps or scripts.]

TODOs

[List any outstanding TODOs or known issues that still need to be addressed.]

@kreneskyp kreneskyp merged commit 7ba936c into master Feb 4, 2024
7 checks passed
@kreneskyp kreneskyp deleted the jsonschema_tool_description branch February 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant