Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dataloader, PersonType, and some data to test it. #1303

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
"classnames": "^2.2.5",
"cookie-parser": "^1.4.3",
"core-js": "^2.4.1",
"dataloader": "^1.3.0",
"express": "^4.15.2",
"express-graphql": "^0.6.4",
"dataloader": "^1.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataloader two times

"express": "^4.15.3",
"express-graphql": "^0.6.6",
"express-jwt": "^5.3.0",
Expand Down
10 changes: 10 additions & 0 deletions src/data/loaders/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import personLoader from './personLoader';

// All your dataloaders
const allLoaders = {
...personLoader,
};

export default function loaders() {
return allLoaders;
}
6 changes: 6 additions & 0 deletions src/data/loaders/personLoader.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import DataLoader from 'dataloader';
import getPerson from '../queries/getPerson';

export default {
personLoader: new DataLoader(people => Promise.all(people.map(_id => getPerson(_id)))),
};
23 changes: 23 additions & 0 deletions src/data/queries/getAllPeople.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* React Starter Kit (https://www.reactstarterkit.com/)
*
* Copyright © 2014-present Kriasoft, LLC. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE.txt file in the root directory of this source tree.
*/

import { GraphQLList as List } from 'graphql';
import PersonType from '../types/PersonType';
import allPeople from '../seed/people';

/* eslint-disable no-underscore-dangle */
const getAllPeople = {
type: new List(PersonType),
resolve: async (req, args, { loaders }) => {
const people = allPeople.map((person => person._id));
return loaders.personLoader.loadMany(people);
},
};

export default getAllPeople;
22 changes: 22 additions & 0 deletions src/data/queries/getPerson.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/**
* React Starter Kit (https://www.reactstarterkit.com/)
*
* Copyright © 2014-present Kriasoft, LLC. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE.txt file in the root directory of this source tree.
*/

import allPeople from '../seed/people';

/* eslint-disable no-underscore-dangle */
export default function getPerson(_id) {
let response = null;
try {
response = allPeople.find(people => people._id === _id);
} catch (err) {
/* eslint-disable no-console */
console.log('getPerson err', err);
}
return response;
}
2 changes: 2 additions & 0 deletions src/data/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ import {

import me from './queries/me';
import news from './queries/news';
import people from './queries/getAllPeople';

const schema = new Schema({
query: new ObjectType({
name: 'Query',
fields: {
me,
news,
people,
},
}),
});
Expand Down
63 changes: 63 additions & 0 deletions src/data/seed/people.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
export default [
{
_id: 'person_1',
name: 'Davey Edwards',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_2',
name: 'Konstantin Tarkus',
friends: ['person_1', 'person_2', 'person_3', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_3',
name: 'Lee Byron',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_4',
name: 'Laney Kuenzel',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_5',
name: 'Max Stoiber',
friends: ['person_1', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_6',
name: 'Jing Chen',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10'],
}, {
_id: 'person_7',
name: 'Tyler McGinnis',
friends: ['person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_8',
name: 'Ryan Florence',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_9',
name: 'Michael Jackson',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_10',
name: 'Dan Abramov',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_11',
name: 'Tom Occhino',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_9', 'person_9', 'person_10', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_12',
name: 'Pete Hunt',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_11', 'person_12', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_13',
name: 'Joe Savona',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_14', 'person_15'],
}, {
_id: 'person_14',
name: 'Lin Clark',
friends: ['person_1', 'person_2', 'person_3', 'person_4', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_13', 'person_14', 'person_15'],
}, {
_id: 'person_15',
name: 'Dan Schafer',
friends: ['person_1', 'person_2', 'person_5', 'person_6', 'person_7', 'person_8', 'person_9', 'person_9', 'person_10', 'person_13', 'person_14', 'person_15'],
},
];
27 changes: 27 additions & 0 deletions src/data/types/PersonType.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
/**
* React Starter Kit (https://www.reactstarterkit.com/)
*
* Copyright © 2014-present Kriasoft, LLC. All rights reserved.
*
* This source code is licensed under the MIT license found in the
* LICENSE.txt file in the root directory of this source tree.
*/

import {
GraphQLObjectType as ObjectType,
GraphQLString as StringType,
GraphQLList as List,
} from 'graphql';

const PersonType = new ObjectType({
name: 'Person',
fields: () => ({
name: { type: StringType },
friends: {
type: new List(PersonType),
resolve: (person, args, { loaders }) => loaders.personLoader.loadMany(person.friends),
},
}),
});

export default PersonType;
4 changes: 4 additions & 0 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import models from './data/models';
import schema from './data/schema';
import assets from './assets.json'; // eslint-disable-line import/no-unresolved
import config from './config';
import loaders from './data/loaders';

const app = express();

Expand Down Expand Up @@ -90,6 +91,9 @@ app.use('/graphql', expressGraphQL(req => ({
graphiql: __DEV__,
rootValue: { request: req },
pretty: __DEV__,
context: {
loaders: loaders(),
},
})));

//
Expand Down
4 changes: 4 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2005,6 +2005,10 @@ dashdash@^1.12.0:
dependencies:
assert-plus "^1.0.0"

dataloader@^1.3.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/dataloader/-/dataloader-1.3.0.tgz#6fec5be4b30a712e4afd30b86b4334566b97673b"

date-fns@^1.27.2:
version "1.28.5"
resolved "https://registry.yarnpkg.com/date-fns/-/date-fns-1.28.5.tgz#257cfc45d322df45ef5658665967ee841cd73faf"
Expand Down