Changed gulp implementation #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and all shared variables into one config file. gulp/index.js iterates over all .js files in gulp/tasks and requires them for gulp
|
Just noticed your comment on #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
Newer to React but I've been using this code to familiarize myself and decided to make a PR for the implementation of gulp that I personally use (in case everyone prefers it). It's not an original idea, I know of a few other projects that use this format.
Anyways, as it says in the commit, I separated all gulp tasks into gulp/tasks/. The gulpfile.js now just requires gulp/index.js which then iterates the tasks directory for all .js files and requires them. All shared variables that were in gulpfile.js are now in gulp/config.js. I have tested gulp and all tasks still work as expected. I personally use it to make tasks more readable and easier to add.