fix: add Emoji Compat font to prevent connections to Google #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheOneWithTheBraid <[email protected]>
|
This pull request is stale because it has been open for 120 days with no activity. |
github-actions
bot
added
the
stale
|
This pull request was closed because it has been inactive for 14 days since being marked as stale. |
Closed
Closed
|
Should this be reopened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR moves the discussion about https://gitlab.com/famedly/fluffychat/-/merge_requests/1124#note_1408677152 to a dedicated MR.
These three Noto font families are hardcoded in the Flutter engine to be loaded as fallback
from Google Fonts in case characters are supposed to be displayed that are not available in
the provided fonts.
The fonts may NOT be renamed in their family name we use in Dart.
Source : https://github.com/flutter/engine/blob/3.10.2/lib/web_ui/lib/src/engine/canvaskit/font_fallback_data.dart
Note: Two of the three mentioned fonts (
Noto Color EmojiandNoto Sans Symbols) are already bundled with FLuffyChat and don't require any adjustment.This MR likely needs discussion, while it's relevant for privacy, it drops in the regression of 11 MiB bigger app packages.