Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tg-forward #574

Closed
wants to merge 1 commit into from
Closed

Conversation

Decodetalkers
Copy link
Contributor

replace tg-forward block to ''

this make tg-forward can be shown

Log:

@Decodetalkers
Copy link
Contributor Author

@krille-chan I have fixed tg-forward, make the part visible, can you review it?

replace tg-forward block to ''

Log:
@krille-chan
Copy link
Owner

Can you elaborate more what this is about?

@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Sep 17, 2023

telegram has a message is , the message my side received is like

<tg-forward>
    <blockquote>
message content
   </blockquote>
</tg-forward>

because the xml has <tg-forward> part, the part of <blockquote> can not be rendered, it become empty, then I cannot view the forward message here, so I try to make the keyword to empty , make blockquote be rendered

@q234rty
Copy link
Contributor

q234rty commented Sep 18, 2023

I guess this fixed #507 ?

),
'',
)
.replaceAll(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need two replaceAll methods here. With regex it should be possible to do it in one by selecting the content inside of tg-forward.

@krille-chan
Copy link
Owner

Instead of doing an expensive .replaceAll() action on all messages, I would prefer to just add tg-forward as another allowed tag and render it the same way as blockquotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants