Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #726: Status bar wrong theme in dark mode #791

Closed
wants to merge 6 commits into from

Conversation

itz-shubham
Copy link

As stated by the issuer, this may be a duplicate of issue #32 and/or #59. If so, then close both those issues also.

Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM 👍

@Porkepix
Copy link

@krille-chan Seems like auto-merge encountered an issue here when it was enabled.

auto-merge was automatically disabled May 22, 2024 05:12

Head branch was pushed to by a user without write access

@itz-shubham itz-shubham requested a review from krille-chan May 25, 2024 13:34
@krille-chan krille-chan enabled auto-merge May 27, 2024 06:23
@Porkepix
Copy link

Porkepix commented Jun 3, 2024

@krille-chan Maybe you need to give a positive review as a review was requested?
I don't know if that's the reason, but auto-merge seems to be stuck again…

@itz-shubham itz-shubham disabled auto-merge June 4, 2024 04:13
@krille-chan
Copy link
Owner

@krille-chan Maybe you need to give a positive review as a review was requested? I don't know if that's the reason, but auto-merge seems to be stuck again…

Hello, the reason is that the commits are not signed. Can you maybe sign them and force push to this branch?

@Porkepix
Copy link

@itz-shubham for the signing requirement (I'm not the author of those commits).

@itz-shubham
Copy link
Author

@itz-shubham for the signing requirement (I'm not the author of those commits).

I'm new to the pull request process, so I checked the "Allow edits by maintainers" box. This should allow you to tweak the code or add comments as needed before merging. Meanwhile, I'm learning about GPG and how to sign commits.

@krille-chan
Copy link
Owner

@itz-shubham for the signing requirement (I'm not the author of those commits).

I'm new to the pull request process, so I checked the "Allow edits by maintainers" box. This should allow you to tweak the code or add comments as needed before merging. Meanwhile, I'm learning about GPG and how to sign commits.

Can you please squash your commits to a single one which then has a valid signature? Then we can merge it. If I edit your Pull Request, then I would be the new author in the git history which would be incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants