-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #726: Status bar wrong theme in dark mode #791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. LGTM 👍
@krille-chan Seems like auto-merge encountered an issue here when it was enabled. |
Head branch was pushed to by a user without write access
@krille-chan Maybe you need to give a positive review as a review was requested? |
Hello, the reason is that the commits are not signed. Can you maybe sign them and force push to this branch? |
@itz-shubham for the signing requirement (I'm not the author of those commits). |
I'm new to the pull request process, so I checked the "Allow edits by maintainers" box. This should allow you to tweak the code or add comments as needed before merging. Meanwhile, I'm learning about GPG and how to sign commits. |
Can you please squash your commits to a single one which then has a valid signature? Then we can merge it. If I edit your Pull Request, then I would be the new author in the git history which would be incorrect |
As stated by the issuer, this may be a duplicate of issue #32 and/or #59. If so, then close both those issues also.