Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maybe String decoder #2

Closed
wants to merge 4 commits into from
Closed

Fix Maybe String decoder #2

wants to merge 4 commits into from

Conversation

mattjbray
Copy link
Collaborator

  • Fixes generating a decoder for a Maybe String field.
  • Avoids unnecessary parens in generated types like Maybe String -> Maybe (String) or Maybe Comment -> Maybe (Comment).

@mattjbray mattjbray mentioned this pull request Nov 22, 2015
Closed
@mattjbray mattjbray force-pushed the fix-maybe-string-decoder branch from 6760a71 to f72961c Compare November 28, 2015 23:52
@krisajenkins
Copy link
Owner

Merged! And not a moment too soon. :-)

Thank you sir! This is now out as 0.2.0. :-)

@mattjbray mattjbray deleted the fix-maybe-string-decoder branch February 2, 2016 10:29
mebassett referenced this pull request in mebassett/elm-export Nov 7, 2017
@FPtje
Merge pull request #2 from phaazon/master
9571a1e 
Fix HasDecoder ElmValue
freekh pushed a commit to folq/elm-export that referenced this pull request Sep 10, 2018
@joneshf
Merge pull request krisajenkins#2 from NoRedInk/merge-upstream-2
721af25 
Merge upstream changes 2
freekh pushed a commit to folq/elm-export that referenced this pull request Sep 10, 2018
@supermario
Merge pull request krisajenkins#2 from NoRedInk/master
5a4ed59 
Various improvements from the NoRedInk/ branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjbray @krisajenkins