Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the CoreText render part - address issue #6 from main repo #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojocatplay
Copy link

Address the two issues in the comment:
#6 (comment)
6

@TwentyThreeDegrees
Copy link

Hi there, thanks for this fix to one of the posted issues - however I have recompiled using your fix and I still have exactly the same problem...

@mojocatplay
Copy link
Author

Can I check which font did you use? I am using a fixed-width font and have not test it with other font (sorry) so it could be it.

Or maybe it could be because of issue #7 where line break modes for CoreText and UITextView differ?

@TwentyThreeDegrees
Copy link

It's Courier. I think you're right it might be an issue with the line
breaks...

@mojocatplay
Copy link
Author

It's quite easy to check if the invisible text matches with the coretext overlay by setting the text of the textview from clearColor to blackColor (or whiteColor if background color is dark color).

@TwentyThreeDegrees
Copy link

Ah yes. It absolutely does not line up, the line break occurs in a
different place! And you can't set the line break mode of the UITextView.

@ndrewh
Copy link

ndrewh commented Oct 2, 2013

@TwentyThreeDegrees @mojocatgames Have any of you tried to fix this with iOS 7? I think you were close to the fix.

@ndrewh ndrewh mentioned this pull request Oct 2, 2013
@TwentyThreeDegrees
Copy link

I haven't looked with iOS7 yet to be honest, no, for all I know there might
be better support with some new classes, but no idea as of yet I'm afraid.

On Wed, Oct 2, 2013 at 2:19 AM, NerdYouDontKnow [email protected]:

@TwentyThreeDegrees https://github.com/TwentyThreeDegrees @mojocatgameshttps://github.com/mojocatgamesHave any of you tried to fix this with iOS 7? I think you were close to the
fix.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9#issuecomment-25506958
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants