Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using actual schema name instead of hard-coding "schema" #324

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

eebbesen
Copy link
Contributor

@eebbesen eebbesen commented Dec 31, 2023

#323

Text schema is prepended to the DROP SEQUENCE and setval suggestions instead of using ${schemaObject.name} to get the actual schema.

Here is the output:

ALTER TABLE "public"."days" ALTER "id" DROP DEFAULT;
DROP SEQUENCE "schema"."days_id_seq";
ALTER TABLE "public"."days" ALTER "id" ADD GENERATED BY DEFAULT AS IDENTITY;
SELECT setval('"days_id_seq"', max("id")) FROM "schema"."days";

Copy link
Contributor

sweep-ai bot commented Dec 31, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@eebbesen eebbesen changed the title Using actual schema name instead of hard-codeing "schema" Using actual schema name instead of hard-coding "schema" Dec 31, 2023
@kristiandupont kristiandupont merged commit 2b071bb into kristiandupont:main Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants