Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Linting against an empty schema causes confusing error (βœ“ Sandbox Passed) #330

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 25, 2024

PR Feedback (click)

  • πŸ‘ Sweep Did Well
  • πŸ‘Ž Sweep Needs Improvement

Description

This pull request fixes an issue where linting against an empty schema would cause a confusing error. It adds a check to skip rules processing if no tables or views are found in the schema.

Summary

  • Added a check to skip rules processing if no tables or views are found in the schema.
  • Updated src/engine.js to handle the new check.
  • Updated src/rules/nameCasing.ts to handle the new check.

Fixes #329.


πŸŽ‰ Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

πŸ’‘ To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-ai bot commented Jan 25, 2024

Rollback Files For Sweep

  • Rollback changes to src/engine.js
  • Rollback changes to src/rules/nameCasing.ts

This is an automated message generated by Sweep AI.

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Jan 25, 2024
@kristiandupont kristiandupont merged commit 79e3ae9 into main Jan 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting against an empty schema causes confusing error
1 participant