forked from hollie/misterhouse
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Insteon_TriggerLinc: Add Initial Support for TriggerLinc Devices
Basically just a copy of code for RemoteLincs, however, TriggerLincs support even fewer commands so much of the code was cut down. I put the code in the Security.pm file as these are ostensible security devices, however as noted above, these are very similar to RemoteLincs. Although, they are not that dissimilar from Motion sensors which are also in this file. I don't own a TriggerLinc so this coding is all done blind. Thanks to @JaredF for his testing work. Closes hollie#245
- Loading branch information
Showing
2 changed files
with
221 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cbe4a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the new code--I will test it out tonight!
8cbe4a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out and everything works great so far! Thank you so much!
Actually, I'm not noticing any difference between using this or the MotionLinc declaration which is actually a good thing :) Thanks for working on this; even though it doesn't make a huge difference now, I think it's for the best since it was decided to create individual Insteon devices and move away from using the generic IPLL/IPLD system.
One thing I did notice (though this may be the desired functionality) is that this device is currently treated as a "non-deaf" device so it is included in the "Scan all devices" command which causes the device to be considered "out-of-sync" if it is not woken up at the right time when running the scan. Is this the desired behavior for now since we eventually plan to add the "Sync when device awakes" feature or should the device be made to be deaf until such time? I don't believe I saw this issue with the MotionLinc code, but I could be wrong.
8cbe4a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is currently no is_deaf routine, but there should be. I will add it as an issue, it may take a day or so to code.
8cbe4a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another non-critical issue in case there are more important things to work on.