fix(worker): switch trie backend only after migration is completed

[Pangssu]

No description provided.

[coderabbitai]

Walkthrough

The pull request introduces changes to two files: migration/migrator.go and miner/worker.go. In migrator.go, the code modifies how safe block is handled, transitioning from a numeric representation to an object-based approach. The miner/worker.go changes focus on managing the Kroma MPT activation block, specifically adjusting the state retrieval logic based on the header's timestamp and migration status.

Changes

File	Change Summary
migration/migrator.go	- Replaced safeBlockNum with safeBlock object - Updated conditional checks to use safeBlock properties - Modified IsKromaMPT method to use safeBlock.Time
miner/worker.go	- Updated makeEnv function logic for Kroma MPT activation block - Added conditional check for header timestamp - Set Zktrie configuration based on migration status

Sequence Diagram

sequenceDiagram
    participant Migrator
    participant Worker
    participant Header
    participant StateDB

    Migrator->>Migrator: Process safe block
    Worker->>Header: Check timestamp
    Header-->>Worker: Timestamp details
    Worker->>StateDB: Determine migration status
    StateDB-->>Worker: Migration state
    Worker->>Worker: Configure Zktrie settings

Loading

The sequence diagram illustrates the high-level interaction between the migrator, worker, header, and state database during the migration and block processing workflow.

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

migration/migrator.go (1)

115-115: Consider handling migration errors more robustly.
If this transition fails, the logic merely logs it. Either retry the migration or propagate the error if partial failures require attention.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 573ca24 and c2dc5a2.

📒 Files selected for processing (2)

• migration/migrator.go (1 hunks)
• miner/worker.go (1 hunks)

🔇 Additional comments (4)

migration/migrator.go (3)

107-107: Use of CurrentSafeBlock() is appropriate.
This makes it clear that subsequent migration steps are based on the latest safe block.

---

109-109: Validate boundary condition for skipping migration.
If safeBlock is nil or the migrated reference is at or beyond the safe block, the code continues to the next iteration. Ensure it’s intended to skip in these exact conditions (e.g., consider if you need an off-by-one comparison).

---

112-112: Exiting on Kroma MPT activation is consistent.
This early return avoids performing additional migrations after MPT is enabled.

miner/worker.go (1)

750-751: Toggling the chain config at runtime.
Recording Zktrie = false directly in the chain config might affect downstream consumers of the config. Confirm there’s no concurrency risk from other goroutines or chain config usage patterns.

Would you like to implement a safer approach (e.g., a local-only override) if toggling global configs is not absolutely required?