Single model - Single Term changes #1457

bhanvimenghani · 2025-01-10T09:46:00Z

Description

This pull request introduces the ability for users to configure recommendations based on their specific use case by allowing them to:

Specify a single model (e.g., cost or performance).
Focus on a single term of interest (e.g., short, medium, or long term ).

Few important features of the pr:

This pr now has different functions to handle remote monitoring and local monitoring use cases. Such that the remote monitoring flow remains undisturbed.
It also handles the default use case, wherein if the experiment is does not have model and term settings it defaults to performance model and short term.
Works well with the VPA demo
Documentation added

Here is the link to the Design document supporting this pr.

Quay image to test changes : quay.io/bmenghan/single_model:v10

Fixes # (issue)

Type of change

Bug fix
New feature
Docs update
Breaking change (What changes might users need to make in their application due to this PR?)
Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

New Test X
Functional testsuite

Test Configuration

Kubernetes clusters tested on:
kind

Checklist 🎯

Additional information

Include any additional information such as links, test results, screenshots here

dinogun · 2025-01-16T07:19:31Z

@bhanvimenghani Looks like the build_crc PR check is failing. I'd suggest that you start with kruize-demo changes for the VPA demo that can be used to test this feature as well as add Documentation changes to this PR

bhanvimenghani · 2025-01-24T09:50:15Z

@dinogun the pr is ready for review.

design/KruizeLocalAPI.md

src/main/java/com/autotune/analyzer/kruizeObject/KruizeObject.java

src/main/java/com/autotune/analyzer/kruizeObject/ModelSettings.java

src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java

dinogun · 2025-02-06T06:49:47Z

@bhanvimenghani Please fix the conflicts

src/main/java/com/autotune/analyzer/exceptions/InvalidModelException.java

src/main/java/com/autotune/analyzer/exceptions/InvalidTermException.java

src/main/java/com/autotune/analyzer/kruizeObject/KruizeObject.java

src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java

src/main/java/com/autotune/analyzer/serviceObjects/Converters.java

src/main/java/com/autotune/analyzer/utils/AnalyzerErrorConstants.java

src/main/java/com/autotune/analyzer/exceptions/InvalidTermException.java

src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java

src/main/java/com/autotune/analyzer/exceptions/InvalidModelException.java

khansaad

LGTM!

src/main/java/com/autotune/analyzer/serviceObjects/Converters.java

design/KruizeLocalAPI.md

chandrams · 2025-02-11T11:14:08Z

@msvinaykumar - Please review this PR

chandrams · 2025-02-12T05:15:30Z

src/main/java/com/autotune/analyzer/recommendations/engine/RecommendationEngine.java

+        // Add new models
+        recommendationModels = new ArrayList<>();
+        for (String model : modelName) {
+            if ("cost".equalsIgnoreCase(model)) {


Please use constants here as discussed

chandrams

LGTM

chandrams · 2025-02-12T07:00:53Z

@bhanvimenghani Please ensure there are no regressions by running the functional testsuite

bhanvimenghani requested a review from khansaad January 10, 2025 09:46

bhanvimenghani self-assigned this Jan 10, 2025

bhanvimenghani changed the title ~~[Draft] Single model - Single Term changes~~ Single model - Single Term changes Jan 22, 2025

bhanvimenghani mentioned this pull request Jan 24, 2025

Adding Functionality to Dynamically Calculate Threshold Value For Minimum Time Required For Term #1466

Merged

10 tasks