Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included stress test for Bulk API #1458

Open
wants to merge 4 commits into
base: mvp_demo
Choose a base branch
from

Conversation

chandrams
Copy link
Contributor

Description

Included stress test for Bulk API

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@chandrams chandrams self-assigned this Jan 15, 2025
@chandrams chandrams added this to the Kruize 0.4 Release milestone Jan 22, 2025
@chandrams chandrams marked this pull request as ready for review January 22, 2025 16:20
@chandrams
Copy link
Contributor Author

@msvinaykumar Can you please review this PR

@shreyabiradar07
Copy link
Contributor

@chandrams Can you please rebase this PR with latest mvp demo

Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it works for new format.

@chandrams
Copy link
Contributor Author

@chandrams Can you please rebase this PR with latest mvp demo

Done

@chandrams
Copy link
Contributor Author

Hope it works for new format.

Yes, I have made changes as per the new format. But the tests fail with issues already raised.

if include:
getJobIDURL = url_include

if logger:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the logger condition is repeated multiple times, the logging and printing logic can be moved to a common function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shreya, I have made the changes.

Signed-off-by: Chandrakala Subramanyam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

3 participants