-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Kafka: Initial integration changes #1492
base: mvp_demo
Are you sure you want to change the base?
Conversation
Signed-off-by: Saad Khan <[email protected]>
@khansaad Please add MD file |
Signed-off-by: Saad Khan <[email protected]>
@@ -216,6 +216,8 @@ data: | |||
"experimentsURL" : "http://kruize.monitoring.svc.cluster.local:8080/createExperiment", | |||
"experimentNameFormat" : "%datasource%|%clustername%|%namespace%|%workloadname%(%workloadtype%)|%containername%", | |||
"bulkapilimit" : 1000, | |||
"isKafkaEnabled" : "true", | |||
"kafkaBootstrapServers" : "kruize-kafka-cluster-kafka-bootstrap.kafka.svc.cluster.local:9092", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to set via env variable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create issue to address following
Client Validation Flow:
Authentication: Broker checks client credentials (SASL or TLS certs).
Authorization: Broker verifies the client has the necessary ACLs.
Data Integrity: TLS encryption protects the messages during transmission.
Please verify if this configuration is getting matched with ROS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #1497 to track this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khansaad Are you addressing setting the kafka bootstrap server using env in this PR?
- Using queries, it fetches the list of namespaces, workloads, containers of the connected datasource. | ||
- Creates experiments, one for each container *alpha release. | ||
- Triggers `generateRecommendations` for each container. | ||
- Once the above step returns a success response, Kafka Producer is invoked and the recommendations are pushed into the `recommendations-topic` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khansaad Can you please add examples of the messages that are push'd to the topics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Saad Khan <[email protected]>
@khansaad Can you please resolve the conflicts |
Description
This PR integrates the Kafka changes in Kruize. It contains the basic changes including the new Consumer and Producer files.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here