Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Kafka: Initial integration changes #1492

Open
wants to merge 3 commits into
base: mvp_demo
Choose a base branch
from

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Feb 4, 2025

Description

This PR integrates the Kafka changes in Kruize. It contains the basic changes including the new Consumer and Producer files.

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@khansaad khansaad added the enhancement New feature or request label Feb 4, 2025
@khansaad khansaad added this to the Kruize 0.4 Release milestone Feb 4, 2025
@khansaad khansaad self-assigned this Feb 4, 2025
@msvinaykumar
Copy link
Contributor

@khansaad Please add MD file

Signed-off-by: Saad Khan <[email protected]>
@@ -216,6 +216,8 @@ data:
"experimentsURL" : "http://kruize.monitoring.svc.cluster.local:8080/createExperiment",
"experimentNameFormat" : "%datasource%|%clustername%|%namespace%|%workloadname%(%workloadtype%)|%containername%",
"bulkapilimit" : 1000,
"isKafkaEnabled" : "true",
"kafkaBootstrapServers" : "kruize-kafka-cluster-kafka-bootstrap.kafka.svc.cluster.local:9092",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to set via env variable ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create issue to address following
Client Validation Flow:
Authentication: Broker checks client credentials (SASL or TLS certs).
Authorization: Broker verifies the client has the necessary ACLs.
Data Integrity: TLS encryption protects the messages during transmission.

Please verify if this configuration is getting matched with ROS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #1497 to track this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khansaad Are you addressing setting the kafka bootstrap server using env in this PR?

- Using queries, it fetches the list of namespaces, workloads, containers of the connected datasource.
- Creates experiments, one for each container *alpha release.
- Triggers `generateRecommendations` for each container.
- Once the above step returns a success response, Kafka Producer is invoked and the recommendations are pushed into the `recommendations-topic`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khansaad Can you please add examples of the messages that are push'd to the topics

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chandrams
Copy link
Contributor

@khansaad Can you please resolve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

3 participants