Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables vpa demo to pick up custom term and model #1494

Open
wants to merge 36 commits into
base: mvp_demo
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e68bbb1
adds Model and Term setting class
bhanvimenghani Jan 8, 2025
76a9170
rebase & fix conflicts
bhanvimenghani Feb 6, 2025
5a3cb28
create and list exp api call works
bhanvimenghani Jan 21, 2025
49f6960
adds single custom term settings, removes extra commented code
bhanvimenghani Jan 23, 2025
f77eb8f
adds term details file
bhanvimenghani Jan 23, 2025
07a044f
rebasing
bhanvimenghani Feb 6, 2025
1920548
fixes rm flow
bhanvimenghani Jan 24, 2025
0d33a41
fix for remote monitoring
bhanvimenghani Jan 24, 2025
8469645
adds documentation
bhanvimenghani Jan 24, 2025
69bf434
removes custom term changes
bhanvimenghani Jan 29, 2025
fa4a37d
fixes design and addresses review comments
bhanvimenghani Jan 31, 2025
418de51
remove comments
bhanvimenghani Feb 6, 2025
0639f5e
accodomated review comments
bhanvimenghani Feb 6, 2025
758ac76
fix error message
bhanvimenghani Feb 6, 2025
5f9aca6
adds space
bhanvimenghani Feb 6, 2025
c380147
fixes model name display in error message
bhanvimenghani Feb 6, 2025
52984e2
removes extra exception
bhanvimenghani Feb 6, 2025
34fd4c0
fixing remote mon flow, with vpa changes intacked
bhanvimenghani Feb 7, 2025
2524bcd
address review comments
bhanvimenghani Feb 10, 2025
87e4817
threshold val calculation
bhanvimenghani Feb 11, 2025
b0641e3
modify delete experiment to include rm flag
khansaad Dec 20, 2024
3c07880
fix PR check failure
khansaad Dec 20, 2024
494ffc6
update table names to fix deletion issue and corresponding test changes
khansaad Dec 20, 2024
1df5682
modify delete experiment test function in the test files
khansaad Dec 23, 2024
697ea72
Adding MetadataProfile APIs doc
shreyabiradar07 Feb 3, 2025
13535ba
Fix profile name
shreyabiradar07 Feb 4, 2025
f7fef5d
Refactor files as per review, add flag for fault tolerance tests
khansaad Feb 7, 2025
3155d7a
Updated ubi-minimal 9.5 to latest version
chandrams Feb 7, 2025
c599d9e
Add local monitoring test job in PR check workflow
shreyabiradar07 Jan 2, 2025
1616033
Add build job for local monitoring
shreyabiradar07 Jan 17, 2025
a1bf199
Update results dir path
shreyabiradar07 Jan 23, 2025
46f2ab8
Update artifact actions version to v4
shreyabiradar07 Jan 23, 2025
76a5b51
Fix RBAC issues
bharathappali Feb 6, 2025
a7d0121
adds null check
bhanvimenghani Feb 11, 2025
422d6ea
fixes model name display in error message
bhanvimenghani Feb 6, 2025
1a3a08d
fixes post rebase changes
bhanvimenghani Feb 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions .github/workflows/test-on-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,115 @@ jobs:
path: ./crc_manifest_results.tar
retention-days: 2


# This workflow builds the kruize image and runs an end-to-end test to validate the local monitoring workflow
build_crc_local_monitoring:
# The type of runner that the job will run on
runs-on: ubuntu-20.04

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4
with:
repository: kruize/autotune
- name: Setup Minikube
uses: manusa/[email protected]
with:
minikube version: 'v1.16.0'
kubernetes version: 'v1.19.2'
- name: Build crc
run: |
echo Build crc
pr_number=${{ github.event.pull_request.number }}
echo "pr_number=${pr_number}" >> "$GITHUB_ENV"
./build.sh -i autotune_operator:pr_${pr_number}
docker images | grep autotune
- name: Check cluster info on minikube
run: |
kubectl cluster-info
kubectl get pods -n kube-system
- name: Install Prometheus on minikube
run: |
echo Install Prometheus on minikube
cd scripts
./prometheus_on_minikube.sh -as
- name: Deploy Kruize in crc mode
run: |
echo Deploy kruize in crc mode
echo "***************************************************************"
cp ./manifests/crc/default-db-included-installation/minikube/kruize-crc-minikube.yaml ./manifests/crc/default-db-included-installation/minikube/kruize-crc-minikube.yaml.old
sed -e "s/imagePullPolicy: Always/imagePullPolicy: IfNotPresent/g" ./manifests/crc/default-db-included-installation/minikube/kruize-crc-minikube.yaml.old > ./manifests/crc/default-db-included-installation/minikube/kruize-crc-minikube.yaml
cat ./manifests/crc/default-db-included-installation/minikube/kruize-crc-minikube.yaml
cd tests
echo "PR_NUMBER = ${{ env.pr_number }}"
./test_autotune.sh -c minikube -i autotune_operator:pr_${{ env.pr_number }} --testsuite=local_monitoring_tests --testcase=test_e2e --resultsdir=${GITHUB_WORKSPACE}
- name: Capture ffdc logs
if: always()
run: |
echo "Capturing ffdc logs"
./scripts/ffdc.sh -m crc -d ${GITHUB_WORKSPACE}/kruize_test_results
- name: Archive results
if: always()
run: |
cd ${GITHUB_WORKSPACE}
tar cvf kruize_build_crc_lm_test_results.tar kruize_test_results

- name: Upload results
if: always()
uses: actions/upload-artifact@v4
with:
name: kruize-build-crc-lm-test-results
path: ./kruize_build_crc_lm_test_results.tar
retention-days: 2


# This job runs an end-to-end test to validate the local monitoring workflow
test_crc_manifest_build_local_monitoring:
# The type of runner that the job will run on
runs-on: ubuntu-20.04

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4
- name: Setup Minikube
uses: manusa/[email protected]
with:
minikube version: 'v1.16.0'
kubernetes version: 'v1.19.2'

- name: Check cluster info on minikube
run: |
kubectl cluster-info
kubectl get pods -n kube-system

- name: Install Prometheus on minikube
run: |
echo Install Prometheus on minikube
cd scripts
./prometheus_on_minikube.sh -as

- name: Test with manifest kruize build in crc mode
run: |
echo Test with manifest kruize build in crc mode
echo "***************************************************************"
cd tests
./test_autotune.sh -c minikube --testsuite=local_monitoring_tests --testcase=test_e2e --resultsdir=${GITHUB_WORKSPACE}

- name: Capture ffdc logs
if: always()
run: |
./scripts/ffdc.sh -m crc -d ${GITHUB_WORKSPACE}/kruize_test_results

- name: Archive results
if: always()
run: |
cd ${GITHUB_WORKSPACE}
tar cvf kruize_local_monitoring_test_results.tar kruize_test_results

- name: Upload results
if: always()
uses: actions/upload-artifact@v4
with:
name: kruize-local-monitoring-test-results
path: ./kruize_local_monitoring_test_results.tar
retention-days: 2
4 changes: 2 additions & 2 deletions Dockerfile.autotune
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
##########################################################
# Build Docker Image
##########################################################
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.5-1736404155 as mvnbuild-jdk21
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.5-1738816775 as mvnbuild-jdk21
ARG USER=autotune
ARG AUTOTUNE_HOME=/home/$USER

Expand Down Expand Up @@ -48,7 +48,7 @@ RUN jlink --strip-debug --compress 2 --no-header-files --no-man-pages --module-p
# Runtime Docker Image
##########################################################
# Use ubi-minimal as the base image
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.5-1736404155
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.5-1738816775

ARG AUTOTUNE_VERSION
ARG USER=autotune
Expand Down
Loading