Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bulk format Demo fix #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

msvinaykumar
Copy link
Contributor

@msvinaykumar msvinaykumar commented Jan 28, 2025

[vinakuma@vinakuma-thinkpadp1gen3 bulk_demo]$ ./bulk_service_demo.sh -c openshift -i quay.io/vinakuma/autotune_operator:shk4

#######################################
# Kruize Demo Setup on openshift 
#######################################

🔄 Pulling required repositories... ✅ Done!
🔄 Installing kruize! Please wait.....................✅ Installation of kruize complete!
🔄 Installing metric profile...✅ Installation of metric profile complete!
🔄 Invoking bulk service...✅ Invoked job_id 669fe19c-0c71-400d-9098-77d2725f27d2
🔔 Bulk job experiment details are currently being updated in ./kruize-bulk-demo.log.
🔄 Processing 138 experiments. Please wait.....✅ Complete!
🔄 Fetching the experiments...✅ Complete!
🔄 List the recommendations for 1 experiments....✅ Complete!
📌 List of all experiments available in experiment_list.txt
📌 Recommendations for a single container in cluster can be found in recommendations_data.json.
📌 Job status is available in job_status.json


ℹ️  Access kruize UI at http://kruize-ui-nginx-service-openshift-tuning.apps.kruize.lab.psi.pnq2.redhat.com
🔖 To explore further, access kruize UI to list and create experiments, and to view or generate recommendations!
ℹ️  For kruize CLI commands, refer to the end of ./kruize-bulk-demo.log

🛠️ Kruize installation took 91 seconds
🚀 Kruize experiment creation and recommendations generation took 133 seconds
🕒 Success! Kruize demo setup took 226 seconds

For detailed logs, look in kruize-bulk-demo.log

Logs attached
kruize-bulk-demo.log
job_status.json

@msvinaykumar
Copy link
Contributor Author

@@ -707,6 +707,10 @@ function get_urls() {
export TECHEMPOWER_URL="${KIND_IP}:${TECHEMPOWER_PORT}"
fi

elif [ ${CLUSTER_TYPE} == "local" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used in bulk demo? Do we need to document this?

exp_count=1
counter=0
exp_count = 1
counter = 0
if exp_list != "":
print("✅ Complete!")
print(f"🔄 List the recommendations for {exp_count} experiments...", end="")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to fetch the recommendations from the job status output instead of list recommendations API as per the new Bulk API format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants