-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bulk format Demo fix #123
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
@@ -707,6 +707,10 @@ function get_urls() { | |||
export TECHEMPOWER_URL="${KIND_IP}:${TECHEMPOWER_PORT}" | |||
fi | |||
|
|||
elif [ ${CLUSTER_TYPE} == "local" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used in bulk demo? Do we need to document this?
exp_count=1 | ||
counter=0 | ||
exp_count = 1 | ||
counter = 0 | ||
if exp_list != "": | ||
print("✅ Complete!") | ||
print(f"🔄 List the recommendations for {exp_count} experiments...", end="") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to fetch the recommendations from the job status output instead of list recommendations API as per the new Bulk API format
Logs attached
kruize-bulk-demo.log
job_status.json