-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Github Workflow for ui [WIP] #227
Open
bhanvimenghani
wants to merge
2
commits into
kruize:mvp_demo
Choose a base branch
from
bhanvimenghani:workflow
base: mvp_demo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have you verified this in your local repo? |
i have verified this in my local repo |
Yes, but the last stage failed. |
yes, unit tests needs to be re-done. |
bhanvimenghani
force-pushed
the
workflow
branch
from
November 25, 2024 13:24
66d8a91
to
36a6481
Compare
Hmm, I see. Can we hold this PR till all stages are successful? |
sure |
Can you add WIP/ convert it to a draft till resolve of all stages? |
bhanvimenghani
changed the title
Adding Github Workflow for ui
Adding Github Workflow for ui [WIP}
Dec 2, 2024
bhanvimenghani
changed the title
Adding Github Workflow for ui [WIP}
Adding Github Workflow for ui [WIP]
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a github workflow which would be triggered while creating a pr or pushing to the main & mvp_demo branch.
Workflow deploys kruize, builds ui and runs test once proper testing is setup.