Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Github Workflow for ui [WIP] #227

Open
wants to merge 2 commits into
base: mvp_demo
Choose a base branch
from

Conversation

bhanvimenghani
Copy link
Contributor

This pr adds a github workflow which would be triggered while creating a pr or pushing to the main & mvp_demo branch.
Workflow deploys kruize, builds ui and runs test once proper testing is setup.

@bhanvimenghani bhanvimenghani linked an issue Nov 14, 2024 that may be closed by this pull request
@athiruma
Copy link
Contributor

Have you verified this in your local repo?

@athiruma
Copy link
Contributor

Screenshot 2024-11-21 at 4 26 51 PM Please take care of these warnings. Update actions/setup-node@v3 -> actions/setup-node@v4

@bhanvimenghani
Copy link
Contributor Author

i have verified this in my local repo

@athiruma
Copy link
Contributor

i have verified this in my local repo

Yes, but the last stage failed.

@bhanvimenghani
Copy link
Contributor Author

yes, unit tests needs to be re-done.

@athiruma
Copy link
Contributor

yes, unit tests needs to be re-done.

Hmm, I see. Can we hold this PR till all stages are successful?

@bhanvimenghani
Copy link
Contributor Author

sure

@athiruma
Copy link
Contributor

athiruma commented Dec 1, 2024

sure

Can you add WIP/ convert it to a draft till resolve of all stages?

@bhanvimenghani bhanvimenghani changed the title Adding Github Workflow for ui Adding Github Workflow for ui [WIP} Dec 2, 2024
@bhanvimenghani bhanvimenghani changed the title Adding Github Workflow for ui [WIP} Adding Github Workflow for ui [WIP] Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup a github workflow to automate testing prs in the ui.
2 participants