Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds QoS 1 PUBACK wait timeout #16

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

mitjaziv
Copy link
Contributor

Change introduces WaitTimeout on message publish.
Client will only wait limited amount of time on PUBACK package.

Change was implemented because some IoT platforms for example AWS IoT Core rate limit QoS 1 messages. When rate limit is reached message is dropped, so client will never get PUBACK package and this results in benchmark tool to hang for ever.

In real time scenario, after wait timeout occurrences client would retry sending package, but for mqtt-benchmark tool this is actually not needed.

Use case would be WaitTimeout is set to few seconds for example 5. But mqtt-benchmark default value is 60 sec, so default behavior is similar to not having timeout.

Change introduces WaitTimeout on message publish.
Client will only wait limited amount of time on PUBACK package.
@krylovsk
Copy link
Owner

Thanks for the contribution, looks good to me.

@krylovsk krylovsk merged commit e576ca4 into krylovsk:master Nov 15, 2020
@krylovsk krylovsk added this to the v0.2 milestone Nov 21, 2020
@mitjaziv mitjaziv deleted the add-wait-timeout branch November 21, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants