Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change introduces WaitTimeout on message publish.
Client will only wait limited amount of time on PUBACK package.
Change was implemented because some IoT platforms for example AWS IoT Core rate limit QoS 1 messages. When rate limit is reached message is dropped, so client will never get
PUBACK
package and this results in benchmark tool to hang for ever.In real time scenario, after wait timeout occurrences client would retry sending package, but for
mqtt-benchmark
tool this is actually not needed.Use case would be WaitTimeout is set to few seconds for example 5. But
mqtt-benchmark
default value is 60 sec, so default behavior is similar to not having timeout.