Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup unused exceptions #166

Closed
marc0olo opened this issue Jul 5, 2021 · 2 comments · Fixed by #217
Closed

cleanup unused exceptions #166

marc0olo opened this issue Jul 5, 2021 · 2 comments · Fixed by #217
Assignees
@mitch-lbw
Labels
refactoring

Comments

@marc0olo
Copy link
Member

marc0olo commented Jul 5, 2021 •
edited
Loading

in the exception package we have originally defined a lot of exceptions we don't make use of

image
@marc0olo
Copy link
Member Author

marc0olo commented Jul 5, 2021

additionally I saw that private TransactionCreateException createException(Exception e) is being called at some places where it doesn't really make sense

@marc0olo
Copy link
Member Author

instead of a cleanup we could also think about actually introducing meaningful exceptions. not sure how we to that right now. what do you think @mitch-lbw ?

@mitch-lbw mitch-lbw self-assigned this Jan 4, 2022
@mitch-lbw mitch-lbw mentioned this issue Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitch-lbw mitch-lbw

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added javadoc, removed unused exceptions kryptokrauts/aepp-sdk-java
2 participants
@marc0olo @mitch-lbw