-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added javadoc, removed unused exceptions #217
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #217 +/- ##
============================================
+ Coverage 11.24% 11.27% +0.03%
Complexity 150 150
============================================
Files 163 152 -11
Lines 3754 3743 -11
Branches 139 139
============================================
Hits 422 422
+ Misses 3306 3295 -11
Partials 26 26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good. have some suggestions and one question
src/main/java/com/kryptokrauts/aeternity/sdk/util/EncodingUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kryptokrauts/aeternity/sdk/domain/ObjectResultWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kryptokrauts/aeternity/sdk/service/mdw/MiddlewareService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kryptokrauts/aeternity/sdk/service/mdw/MiddlewareService.java
Outdated
Show resolved
Hide resolved
…s.java Co-authored-by: Marco Walz <[email protected]>
…ewareService.java Co-authored-by: Marco Walz <[email protected]>
…ewareService.java Co-authored-by: Marco Walz <[email protected]>
Closes #166 Closes #169