Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added javadoc, removed unused exceptions #217

Merged
merged 6 commits into from
Jan 5, 2022

Conversation

mitch-lbw
Copy link
Member

@mitch-lbw mitch-lbw commented Jan 4, 2022

Closes #166 Closes #169

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #217 (6101437) into 3.x (70422d1) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6101437 differs from pull request most recent head 615250d. Consider uploading reports for the commit 615250d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #217      +/-   ##
============================================
+ Coverage     11.24%   11.27%   +0.03%     
  Complexity      150      150              
============================================
  Files           163      152      -11     
  Lines          3754     3743      -11     
  Branches        139      139              
============================================
  Hits            422      422              
+ Misses         3306     3295      -11     
  Partials         26       26              
Impacted Files Coverage Δ
...krauts/aeternity/sdk/constants/ApiIdentifiers.java 100.00% <ø> (ø)
.../kryptokrauts/aeternity/sdk/constants/Network.java 70.00% <ø> (ø)
...auts/aeternity/sdk/domain/ObjectResultWrapper.java 0.00% <ø> (ø)
...auts/aeternity/sdk/domain/StringResultWrapper.java 0.00% <ø> (ø)
...nity/sdk/domain/secret/DeterministicHierarchy.java 76.56% <ø> (ø)
...sdk/domain/secret/DeterministicHierarchyEntry.java 82.60% <ø> (ø)
...okrauts/aeternity/sdk/domain/secret/HdKeyPair.java 80.00% <ø> (ø)
...tokrauts/aeternity/sdk/domain/secret/HdWallet.java 100.00% <ø> (ø)
...ptokrauts/aeternity/sdk/domain/secret/KeyPair.java 73.33% <ø> (ø)
...okrauts/aeternity/sdk/exception/AENSException.java 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70422d1...615250d. Read the comment docs.

@mitch-lbw mitch-lbw closed this Jan 4, 2022
@mitch-lbw mitch-lbw reopened this Jan 4, 2022
Copy link
Member

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. have some suggestions and one question

@mitch-lbw mitch-lbw merged commit 7b74806 into 3.x Jan 5, 2022
@marc0olo marc0olo deleted the refactoring/javadoc-and-exception-cleanup branch January 5, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve javadocs & fix warnings if present cleanup unused exceptions
3 participants