Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delegation signatures #171

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Conversation

marc0olo
Copy link
Member

@marc0olo marc0olo commented Jul 7, 2021

closes #154

Copy link
Member

@mitch-lbw mitch-lbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #171 (4895c94) into 3.x (447febc) will decrease coverage by 0.15%.
The diff coverage is 0.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #171      +/-   ##
============================================
- Coverage     13.66%   13.51%   -0.16%     
- Complexity      148      150       +2     
============================================
  Files           137      145       +8     
  Lines          3029     3137     +108     
  Branches         76       78       +2     
============================================
+ Hits            414      424      +10     
- Misses         2589     2687      +98     
  Partials         26       26              
Impacted Files Coverage Δ
...com/kryptokrauts/aeternity/sdk/constants/AENS.java 0.00% <0.00%> (ø)
...krauts/aeternity/sdk/constants/VirtualMachine.java 27.27% <ø> (+4.19%) ⬆️
...ts/aeternity/sdk/service/ServiceConfiguration.java 2.94% <0.00%> (-0.09%) ⬇️
...rvice/aeternity/AeternityServiceConfiguration.java 0.00% <0.00%> (ø)
...k/service/delegation/DelegationServiceFactory.java 0.00% <0.00%> (ø)
...service/delegation/impl/DelegationServiceImpl.java 0.00% <0.00%> (ø)
...ernity/sdk/service/info/domain/ApiModelMapper.java 0.00% <0.00%> (ø)
...ity/sdk/service/info/domain/TransactionResult.java 0.00% <0.00%> (ø)
...rnity/sdk/service/name/domain/NameEntryResult.java 0.00% <0.00%> (ø)
.../sdk/service/transaction/domain/DryRunRequest.java 0.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8f570...4895c94. Read the comment docs.

@marc0olo marc0olo merged commit 84f5f78 into 3.x Jul 7, 2021
@marc0olo marc0olo deleted the feature/delegation-signatures branch July 7, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve developer experience for delegation signatures
3 participants