Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187: added deposit handling on contract create call #188

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

mitch-lbw
Copy link
Member

No description provided.

@mitch-lbw mitch-lbw requested a review from marc0olo September 5, 2021 15:19
@codecov-commenter
Copy link

Codecov Report

Merging #188 (3796f28) into 3.x (468d625) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #188      +/-   ##
============================================
- Coverage     13.19%   13.18%   -0.01%     
  Complexity      150      150              
============================================
  Files           145      145              
  Lines          3214     3216       +2     
  Branches         80       81       +1     
============================================
  Hits            424      424              
- Misses         2764     2766       +2     
  Partials         26       26              
Impacted Files Coverage Δ
...ion/type/model/ContractCreateTransactionModel.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468d625...3796f28. Read the comment docs.

@mitch-lbw mitch-lbw linked an issue Sep 6, 2021 that may be closed by this pull request
@marc0olo marc0olo merged commit ef038e4 into 3.x Sep 21, 2021
@marc0olo marc0olo deleted the enhancement/187-force-zero-deposit-for-contract branch September 21, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforce zero value for deposit param of ContractCreateTx
3 participants