Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: contract related improvements #206

Merged
merged 8 commits into from
Dec 20, 2021

Conversation

marc0olo
Copy link
Member

@marc0olo marc0olo commented Dec 18, 2021

closes #202, #203 & #207

@marc0olo marc0olo requested a review from mitch-lbw December 18, 2021 00:42
@marc0olo marc0olo marked this pull request as draft December 18, 2021 00:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #206 (a0838c8) into 3.x (496070f) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #206      +/-   ##
============================================
- Coverage     12.57%   12.50%   -0.08%     
  Complexity      150      150              
============================================
  Files           150      150              
  Lines          3371     3375       +4     
  Branches         88       84       -4     
============================================
- Hits            424      422       -2     
- Misses         2921     2927       +6     
  Partials         26       26              
Impacted Files Coverage Δ
...okrauts/aeternity/sdk/constants/BaseConstants.java 0.00% <0.00%> (ø)
.../kryptokrauts/aeternity/sdk/constants/Network.java 70.00% <ø> (-5.00%) ⬇️
...auts/aeternity/sdk/domain/ObjectResultWrapper.java 0.00% <ø> (ø)
...rvice/aeternity/AeternityServiceConfiguration.java 0.00% <0.00%> (ø)
...y/sdk/service/aeternity/impl/AeternityService.java 0.00% <0.00%> (ø)
...rvice/compiler/impl/SophiaCompilerServiceImpl.java 0.00% <0.00%> (ø)
.../sdk/service/transaction/domain/DryRunRequest.java 0.00% <0.00%> (ø)
...rvice/transaction/impl/TransactionServiceImpl.java 0.00% <0.00%> (ø)
.../service/transaction/type/AbstractTransaction.java 0.00% <ø> (ø)
...transaction/type/impl/ContractCallTransaction.java 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496070f...a0838c8. Read the comment docs.

@marc0olo marc0olo force-pushed the contract-interaction-improvements branch from 258c435 to b7ff4aa Compare December 18, 2021 04:49
@marc0olo marc0olo marked this pull request as ready for review December 18, 2021 04:59
@marc0olo marc0olo force-pushed the contract-interaction-improvements branch from 103a5e1 to b238342 Compare December 18, 2021 12:02
@marc0olo
Copy link
Member Author

@mitch-lbw can we merge this now? :-)

Copy link
Member

@mitch-lbw mitch-lbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values for amount, gas and gasPrice
3 participants