Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow usage of custom keypair in stateful convenience methods #231

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

marc0olo
Copy link
Member

@marc0olo marc0olo commented Feb 1, 2022

closes #230

@marc0olo marc0olo requested a review from mitch-lbw February 1, 2022 17:57
@codecov-commenter
Copy link

Codecov Report

Merging #231 (871b098) into 3.x (c03ca1c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #231      +/-   ##
============================================
- Coverage     11.27%   11.25%   -0.03%     
  Complexity      150      150              
============================================
  Files           152      152              
  Lines          3743     3750       +7     
  Branches        139      141       +2     
============================================
  Hits            422      422              
- Misses         3295     3302       +7     
  Partials         26       26              
Impacted Files Coverage Δ
.../service/transaction/domain/ContractTxOptions.java 0.00% <0.00%> (ø)
...rvice/transaction/impl/TransactionServiceImpl.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03ca1c...871b098. Read the comment docs.

Copy link
Member

@mitch-lbw mitch-lbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marc0olo marc0olo merged commit 991d2ff into 3.x Feb 1, 2022
@marc0olo marc0olo deleted the feat/allow-custom-keypair branch February 1, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow usage of custom KeyPair in contract related convenience methods
3 participants