Remove Email Auth #664
Merged
Remove Email Auth #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
codekansas
requested changes
Dec 25, 2024
www/app/utils/email.py
Outdated
|
|
||
| await send_email(subject="Signup", body=body, to=email) | ||
|
|
||
|
|
||
| async def send_reset_password_email(email: str, token: str) -> None: |
There was a problem hiding this comment.
we should also be able to remove this function, as well as the change email function below - basically, any functionality related to managing the user's email and password
codekansas
requested changes
Dec 25, 2024
codekansas
previously requested changes
Dec 25, 2024
www/app/routers/users.py
Outdated
| @@ -95,7 +94,6 @@ async def delete_user_endpoint( | |||
| crud: Annotated[Crud, Depends(Crud.get)], | |||
| ) -> bool: | |||
| await crud.delete_user(user.id) | |||
| await send_delete_email(user.email) | |||
There was a problem hiding this comment.
wait, actually this is important - we should keep this part
codekansas
reviewed
Dec 25, 2024
tests/test_users.py
Outdated
| mock_send_email.assert_called_with( | ||
| subject="Account Deleted - K-Scale Labs", | ||
| body=mock_send_email.call_args[1]["body"], # Don't compare exact HTML | ||
| to="[email protected]", # This is the mock email from conftest.py |
There was a problem hiding this comment.
this was changed to [email protected]
- Remove email router and CRUD operations - Remove EmailSignUpToken model - Remove email-specific utility functions - Update imports and references This change removes the email-based authentication system as we no longer allow email authentication. Co-Authored-By: Benjamin Bolte <[email protected]>
…il, send_reset_password_email) Co-Authored-By: Benjamin Bolte <[email protected]>
Co-Authored-By: Benjamin Bolte <[email protected]>
…fication with tests Co-Authored-By: Benjamin Bolte <[email protected]>
Co-Authored-By: Benjamin Bolte <[email protected]>
Co-Authored-By: Benjamin Bolte <[email protected]>
codekansas
force-pushed
the
devin/1697048851-remove-email-auth
branch
from
f696de0 to
a2a6633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all /auth/email endpoints, associated CRUD models, and references.
Changes:
This change removes the email-based authentication system as we no longer allow email authentication.
Link to Devin run: https://app.devin.ai/sessions/e211620112274ec7a462a4e555daeb37