Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Extend GH Actions to also build for ARM #72

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

kimwnasptd
Copy link
Contributor

These changes are aimed to bringing ARM support and updating the Makefiles/CI to look similar to what we do for https://github.com/kubeflow/kubeflow/

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Use buildx in the Makefile for building the image in multiple
architectures.

Signed-off-by: Kimonas Sotirchos <[email protected]>
@kimwnasptd kimwnasptd force-pushed the feature-kimwnasptd-arm branch from dd3a8b3 to 1a838cb Compare June 18, 2023 12:20
@SiddharthPant
Copy link

Hi team, will kindly request to review and approve this as without it its impossible to run a local setup of models-web-app on Apple silicon Macs.

@juliusvonkohout
Copy link
Contributor

CICD is happy so

/lgtm
/approve

Copy link

oss-prow-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [juliusvonkohout,kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout merged commit 3999015 into kserve:master Jun 26, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants