Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The undo function does not work on Crop tool commands. #56

Closed
antrrax opened this issue Aug 18, 2019 · 5 comments
Closed

The undo function does not work on Crop tool commands. #56

antrrax opened this issue Aug 18, 2019 · 5 comments
Assignees
@DamirPorobic
Labels
bug Something isn't working

Comments

@antrrax
Copy link
Contributor

antrrax commented Aug 18, 2019 •
edited
Loading

I use Linux Mint 19.2 x64 Cinnamon
Git clone: August 11, 2019

  1. Do any drawing
    01

  2. Main Menu> Edit > Crop
    02

  3. Move selection to crop image
    03

  4. Mani Menu> Edit > Undo
    04

It should undo step 3, but it undoes step 1
05

The undo function does not work on Crop tool commands.
@antrrax antrrax changed the title The undo function does not act on Crop tool commands. The undo function does not work on Cut tool commands. Aug 19, 2019
@antrrax antrrax changed the title The undo function does not work on Cut tool commands. The undo function does not work on Crop tool commands. Aug 19, 2019
@DamirPorobic DamirPorobic added the bug Something isn't working label Aug 27, 2019
@DamirPorobic
Copy link
Member

Thanks for opening this, looks indeed like a bug

@DamirPorobic
Copy link
Member

It seems to be working on my machine. Could you test again with the AppImage?

crop_with_undo

@DamirPorobic
Copy link
Member

Oh wait, you're clicking on undo before you have actually cropped the image? That of course can't work, the crop is commited after you click on crop.

@DamirPorobic DamirPorobic added invalid This doesn't seem right and removed bug Something isn't working labels Aug 30, 2019
@DamirPorobic
Copy link
Member

The only think that we might need to do here is disable undo&redo during crop operation.

@DamirPorobic DamirPorobic added bug Something isn't working and removed invalid This doesn't seem right labels Sep 1, 2019
DamirPorobic added a commit that referenced this issue Sep 1, 2019
@DamirPorobic
Disable undo/redo during crop and scale #56
59ec199
@DamirPorobic
Copy link
Member

Undo&redo is now disabled during crop and scale operation.

@DamirPorobic DamirPorobic self-assigned this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamirPorobic DamirPorobic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DamirPorobic @antrrax