-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Project abandonment / maintenance #82
Comments
It would be great to see this continue and get updated. It's so useful |
Happy to help |
I'm up for helping as well - looks like there's a bunch of forks: https://github.com/kstyrc/embedded-redis/network This one seems to have the most work behind it: |
Seeing as this hasn't got attention from the author, I think we are free to proceed as we see it fit. I'all do a fork and update to the latest stable redis binary and try to publish. I'll also post an update here to redirect fresh issues to the fork's tracker. Suggestions welcome :) |
Sounds good |
Very good |
Sorry for a late reply. Since long ago I have no time to devote to this project. If you still wanna develop it feel free to fork it. But on the other hand, it would be great to keep it in this repository to guarantee maven repository continuation. |
@krzysztof-styrc completely understand, life can get busy - thanks for getting the project this far, it's very useful! I'm kind of leaning to a new fork that's not dependent on a user path and then pointing people to that, but am open to whatever folks want. |
@krzysztof-styrc Did you build cross-platform binaries yourself? @clamey @MagnusSmith what are your preferred platforms? I have neither resources nor a burning desire to support windows, so this may be a blocker. If someone else thinks they could do it, that's great. |
@MagnusSmith yeah, I'm aware of that, but I see the issue in the fact that windows redis binaries may lag behind the latest stable ones, e.g. current stable is 3.2.8 and the MSOpenTech's is 3.2.1. And, as I said, I have no access to the windows machine and all this fuss with VMs may be too much for me as a person who would never use aspect of the library. |
@tkroman I'm happy to try and support the Windows binaries. It looks like from the RedisExecProvider that we can either attempt a lowest common denominator approach for all platforms or target specific redis versions for different platforms. |
I don't have ready access to Windows - I'm in Linux and OS X land... |
@clamey @tkroman I agree that a fork that is not dependent on a user path would be by far the best way to go. Any ideas how we could go about that? |
To be clear, I meant the distribution artifact name probably shouldn't be tied to a specific user. The GitHub project will have to be under a user - I just think the project will need more than one collaborator who can approve PRs and do releases to avoid a bottle neck.
… On May 10, 2017, at 12:26 PM, Magnus Smith ***@***.***> wrote:
@clamey @tkroman I agree that a fork that is not dependent on a user path would be by far the best way to go. Any ideas how we could go about that?
It is hard to see how pull requests could be handled in kstyrc if @krzysztof-styrc is unavailable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It's practical to start small and just upgrade to latest Redis and Java 8. Other suggestions are all good, but can be discussed as the subsequent steps. @krzysztof-styrc @kstyrc can we start with just this? |
So if we find someone who can provide us with windows builds, that would mean we aren't blocked on anything else. I myself can do OS X builds (and linux, with some effort). |
i'll do linux |
Sooo... windows anyone? |
I'll do windows.
…On Thu, 13 Jul 2017, 20:08 Roman Tkalenko, ***@***.***> wrote:
Sooo... windows anyone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxEDhsdUvobOXbUjV8IoDOFxwskN_yVks5sNmsmgaJpZM4NDcan>
.
|
Has the work discussed above started? Is there a fork that the work is being done on? I Would be interested in both using it and contributing. |
@lucasweb78 @MagnusSmith @maksymkovalenko sorry guys, got buried in work. I think I could find some time to do a Mac OS build & perhaps fork a project, if that's really necessary. @krzysztof-styrc @kstyrc how about distribution? If we did a collective PR with fresh binaries, would you mind releasing an artifact? Also, guys, WDYT about providing builds for 2.x, 3.x & 4.x simultaneously? |
@MagnusSmith can you provide a windows binary for Redis 3.2.11? @kstyrc will be merging my PR for 3.2.11 and releasing in a couple of days. |
@tkroman I just created PR #110 that adds support for all Redis versions, I added binaries for Linux 64 only (don't have access to Win, Mac OS). |
@maksymkovalenko we forked last year under our github organization (https://github.com/spinnaker/embedded-redis) and are building artifacts/etc. You are welcome to submit PRs to our repo. |
Ha-ha, too many new changes on your fork! :) I'll probably have to redo quite a bit of my PR. |
Looks like this project is no longer maintained. @kstyrc correct me if I'm wrong.
If that is true, I'd like to start a discussion to see how much people are interested in a possible fork or ownership transfer so the community can take care of the further evolution.
To everyone interested: please voice your opinions on the matter.
The text was updated successfully, but these errors were encountered: