-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes IE9 after reading more and colapsing about 5 times. #24
Comments
very odd. does this happen under any particular conditions? or does it happen, for example, with every example at http://plugins.learningjquery.com/expander/demo/ ? |
Hey Karl.. I just click back and forth between the read more / read less links below the first example.. this time it took me a whole minute, but it crashed IE.. fourth time now.. FYI, I have an I7 with 12GB of RAM running Windows 7 64bit so I don't think it’s a memory issue.. I like the plugin, seems to handle truncating in the middle of the HTML well so I recommended it for use on a site we're working on... Hopefully this issue is only IE specific. :) Let me know if you want me to send you a camtasia video.. Robert C. Wafle -----Original Message----- very odd. does this happen under any particular conditions? or does it happen, for example, with every example at http://plugins.learningjquery.com/expander/demo/ ? Reply to this email directly or view it on GitHub: |
I found your plugin today, works great in Firefox and Chrome, but same issue of it crashing in IE. Tested on two different machines, same problem. When you click between the close and open options it eventually crashes (Anywhere between 1 to 15 attempts). Great plugin though, once the bug is resolved I will use it live on my site. |
I am so sorry about this bug! I hardly know where to start, though, since I haven't been able to reproduce it. @berridgeab : where are you seeing the crash? on the demo page? Which version of IE? Is there any pattern at all to when it crashes IE? Do you have any extensions installed in the browser? How many other tabs open? Any additional information at all would be really helpful. |
One more thing ... I'm wondering if it might have something to do with the expand/collapse functions using fadeIn/fadeOut (IE has historically had a tough time handling opacity in certain situations). Could you try with the following options and see if it still crashes? {
expandEffect: 'show',
expandSpeed: 0,
collapseEffect: 'hide',
collapseSpeed: 0
} |
Hi Thanks for your fast response. First Post - Where are you seeing the crash? Is there any pattern at all to when it crashes IE? Which version of IE? Do you have any extensions installed in the browser? How many other tabs open? Any additional information at all would be really helpful? Post 2 - I can confirm the settings you posted above seem to have solved the issue. I sat for 5 minutes clicking the Expand / Collapse element and there was no crash. SlideUp and SlideDown also seem unaffected. I restored the opacity settings and the crash happened within 5 clicks. I am more bothered about the functionality than the effect. Again thanks for your help with this. |
Hey, thanks again for the reports and the info to help troubleshoot. For now, I've updated the readme with a "Known Issue" section, along with the workaround of changing the *Effect options. I might change the default settings to a non-animating expand/collapse later. What do you think? Can I close this issue? Anything else I should be doing here? |
SlideUp / SlideDown seems to work and looks ok so it may be worthwhile changing that to the default so the plugin can be downloaded in a fully functional state. Again thanks for your work with this plugin it works great. |
Any ideas?
The text was updated successfully, but these errors were encountered: