-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Info & Automatic config for circleci #31
Conversation
I also built a small test project that uses the modified plugin: |
|
||
|
||
@Test | ||
void testCreateFromEnvVarCircleci() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kt3k are you able to explain why this line doesn't hit the branch https://coveralls.io/files/406445698#L26 ?
when running locally it does hit it nicecely when setting a break point
cheers flo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using gradlew or local gradle?
I think the cobertura has a lot of irrational behaviours with groovy 2.x. (It was ok with groovy 1.8 (which is bundled with gradle 1.x)
Thanks for the contribution! For the moment I'm a bit busy for other things, then I need some days to review this change. Please wait. Thanks, |
Git Info & Automatic config for circleci
Sorry for the late response. Thanks for the nice enhancement! I've released this version as v2.1.0 to Maven and Bintray. Thank you very much! |
Did some refactoring and attached some additional info from git