Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jenkins CI support and updating README #33

Merged
merged 1 commit into from
Feb 8, 2015

Conversation

dallasgutauckis
Copy link
Contributor

  • Adds Jenkins CI support (push and pull request)
  • Updates README to show relevant environment variables for custom builds

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.13%) to 83.77% when pulling 7c480bc on seatgeek:pr-jenkins into 0f4e0bb on kt3k:master.

@kt3k
Copy link
Owner

kt3k commented Feb 8, 2015

Really thanks for the enhancement and documentation!

I'll release it soon.

kt3k added a commit that referenced this pull request Feb 8, 2015
Adding Jenkins CI support and updating README
@kt3k kt3k merged commit ecf1709 into kt3k:master Feb 8, 2015
@dallasgutauckis dallasgutauckis deleted the pr-jenkins branch February 8, 2015 04:59
@dallasgutauckis
Copy link
Contributor Author

My pleasure.

@dallasgutauckis
Copy link
Contributor Author

Hey @kt3k I've noticed that this is not showing the right pull number in coveralls.io; I've tried both the direct link and the number. Any idea what the value is supposed to be for the servicePullRequest?

@kt3k
Copy link
Owner

kt3k commented Feb 9, 2015

https://coveralls.zendesk.com/hc/en-us/articles/201770395-Do-you-support-Circle-CI-pull-request-comments-
This post says it should be CircleCI's CI_PULL_REQUEST env var. I'm personally not using CircleCI, then I can't give an example at the moment, but I'll try to check it later.

@kt3k
Copy link
Owner

kt3k commented Feb 9, 2015

https://github.com/circleci/frontend/blob/master/resources/assets/docs/environment-variables.md#build-details
According to this doc, it should be the url of the pull request. Hmm strange...

@dallasgutauckis
Copy link
Contributor Author

The original implementation uses the URL, but coveralls shows "Pull #0" and doesn't link to the correct PR when clicked either. This might need some input from the coveralls team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants