Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds https proxy support. #67

Merged
merged 4 commits into from
Nov 10, 2016
Merged

adds https proxy support. #67

merged 4 commits into from
Nov 10, 2016

Conversation

pomkine
Copy link
Contributor

@pomkine pomkine commented Nov 8, 2016 •
edited
Loading

Adds https.proxyHost and https.proxyPort env vars parsing and passes these values to HTTPBuilder#setProxy
#66

@pomkine pomkine changed the title adds https proxy support. #66 adds https proxy support. Nov 8, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 96.528% when pulling c7e7034 on pomkine:support_https_proxy into 4d03249 on kt3k:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 96.528% when pulling a872f0e on pomkine:support_https_proxy into 4d03249 on kt3k:master.

@coveralls
Copy link

coveralls commented Nov 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-3.5%) to 96.528% when pulling 372a9d7 on pomkine:support_https_proxy into 4d03249 on kt3k:master.

@kt3k
Copy link
Owner

kt3k commented Nov 9, 2016

Thanks for the contribution! The code seems ok. Can you document environment variables in README.md?

@pomkine
Copy link
Contributor Author

pomkine commented Nov 9, 2016

Sure, no problem

@coveralls
Copy link

coveralls commented Nov 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-3.5%) to 96.528% when pulling df9fce3 on pomkine:support_https_proxy into 4d03249 on kt3k:master.

kt3k
kt3k approved these changes Nov 10, 2016
View reviewed changes
Copy link
Owner

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit b41a159 into kt3k:master Nov 10, 2016
@pomkine pomkine deleted the support_https_proxy branch November 10, 2016 15:43
@kt3k
Copy link
Owner

kt3k commented Nov 11, 2016

Published as v2.7.0.

@kt3k kt3k mentioned this pull request Nov 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pomkine @coveralls @kt3k