sync: Add optional check for mounted mountpoint(s) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, if the local folder were inside a filesystem which was not mounted, then bitpocket would likely emit an error that path was not a bitpocket directory. |
greezybacon
force-pushed
the
feature/mountpoint-check
branch
from
1050366 to
237bb2e
Compare
greezybacon
force-pushed
the
feature/mountpoint-check
branch
from
237bb2e to
84bb72f
Compare
If the systems being synced by bitpocket are syncing a special mounted filesystem, then a check can be added to ensure the filesystem is mounted before the sync will begin. This allows for bitpocket to gracefully abort the sync instead of deleting all the local or remote data because of the missing mount (making the sync target appear empty like all the files were removed).
greezybacon
force-pushed
the
feature/mountpoint-check
branch
from
84bb72f to
a91c569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the systems being synced by
bitpocketare syncing a special mounted filesystem, then a check can be added to ensure the filesystem is mounted before the sync will begin. This allows for bitpocket to gracefully abort the sync instead of deleting all the local or remote data because of the missing mount (making the sync target appear empty like all the files were removed).It's possible I'm the only sysadmin with cluster filesystem mounts which are disabled from time to time for maintenance or otherwise become unavailable for whatever reason. Having a background sync remove data on a backup server while the local mount is down just makes the situation that much more frustrating.