Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting to older timestamp format in logs #478

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Reverting to older timestamp format in logs #478

merged 1 commit into from
Sep 26, 2023

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Sep 26, 2023

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

As per our discussion offline https://redhat-internal.slack.com/archives/C05CDC19ZKJ/p1695741562501689,
Reverting to our previous time format in logs.

"2006-01-02 15:04:05"

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested on a local machine.

time="2023-09-26 12:12:06" level=info msg="👽 Initializing prometheus client with URL: https://prometheus-k8s-openshift-monitoring.apps.play-area.perfscale.devcluster.openshift.com" file="prometheus.go:45"
time="2023-09-26 12:12:07" level=info msg="🔥 Starting kube-burner (oldtimeformat@56e243a16053ac5c7998ecb01766c85dba35bd0d) with UUID 6da716de-43ad-4584-96c5-44fb3e00ffb0" file="job.go:97"
time="2023-09-26 12:12:07" level=info msg="📈 Registered measurement: podLatency" file="factory.go:84"
time="2023-09-26 12:12:07" level=debug msg="Preparing create job: node-density-heavy" file="create.go:52"
time="2023-09-26 12:12:07" level=debug msg="Rendering template: postgres-deployment.yml" file="create.go:59"
time="2023-09-26 12:12:07" level=info msg="Job node-density-heavy: 30 iterations with 1 Deployment replicas" file="create.go:96"
time="2023-09-26 12:12:07" level=debug msg="Rendering template: app-deployment.yml" file="create.go:59"

@vishnuchalla
Copy link
Collaborator Author

cc: @paigerube14 @nathan-weinberg

Copy link
Contributor

@afcollins afcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@paigerube14
Copy link
Contributor

/lgtm

@vishnuchalla vishnuchalla merged commit d44263c into kube-burner:master Sep 26, 2023
rsevilla87 pushed a commit to rsevilla87/kube-burner that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants