-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admission controller types #477
Labels
Comments
olix0r
added a commit
to olix0r/polixy
that referenced
this issue
Mar 27, 2021
There's apparently no good way to do admission controllers in kube-rs at the moment. See kube-rs/kube#477
coadler
added a commit
to coadler/kube-rs
that referenced
this issue
Mar 31, 2021
coadler
added a commit
to coadler/kube-rs
that referenced
this issue
Mar 31, 2021
coadler
added a commit
to coadler/kube-rs
that referenced
this issue
Mar 31, 2021
coadler
added a commit
to coadler/kube-rs
that referenced
this issue
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AdmissionReview
/AdmissionRequest
/AdmissionResponse
do not have generated types ink8s-openapi
.This is possibly (speculation) for good reasons; the way they work is very different from a normal api call: https://kubernetes.io/blog/2019/03/21/a-guide-to-kubernetes-admission-controllers/
The types however are present in kuberenetes/api/admission, and don't see how people can do admission controllers without them.
I imagine we could provide a module that hand-rolled those structs, make them generic over the Resource trait, and it might not be that bad?
Have not had much time to look at this, but it could be a nice clean feature for someone to try, and am happy to review PRs. Marking as
help wanted
, but it's probably not easy.Testing wise, a web server would pull in a lot of deps, but maybe we could do something light with
warp
orhyper
as an example.The text was updated successfully, but these errors were encountered: